Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: session visibility in detail panel for < v24.12.0 manager #2887

Merged

Conversation

yomybaby
Copy link
Member

@yomybaby yomybaby commented Nov 26, 2024

Resolve #2886

Please read the #2886 first.

Added a warning message when viewing a session that belongs to a different project. The message is displayed at the top of the session detail page and has been localized across all supported languages.

image.png

Copy link

graphite-app bot commented Nov 26, 2024

Your org requires the Graphite merge queue for merging into main

Add the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added area:ux UI / UX issue. area:i18n Localization size:M 30~100 LoC labels Nov 26, 2024
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

github-actions bot commented Nov 26, 2024

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements
5.27% (-0% 🔻)
395/7498
🔴 Branches
4.57% (-0% 🔻)
237/5188
🔴 Functions 3.16% 78/2472
🔴 Lines
5.18% (-0% 🔻)
380/7330

Test suite run success

124 tests passing in 14 suites.

Report generated by 🧪jest coverage report action from f2a1217

@yomybaby yomybaby force-pushed the fix/2886-graphql-session-visibility-manager-compatibility branch from 2931df7 to 05bf556 Compare November 26, 2024 23:01
@yomybaby yomybaby marked this pull request as ready for review November 26, 2024 23:07
Copy link
Contributor

@agatha197 agatha197 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

graphite-app bot commented Nov 26, 2024

Merge activity

Resolve #2886

Please read the #2886 first.

Added a warning message when viewing a session that belongs to a different project. The message is displayed at the top of the session detail page and has been localized across all supported languages.

![image.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/XqC2uNFuj0wg8I60sMUh/d9d9e168-edf1-4afc-8871-c60a835c3b22.png)
@agatha197 agatha197 force-pushed the fix/2886-graphql-session-visibility-manager-compatibility branch from 05bf556 to f2a1217 Compare November 26, 2024 23:23
@graphite-app graphite-app bot merged commit f2a1217 into main Nov 26, 2024
7 checks passed
@graphite-app graphite-app bot deleted the fix/2886-graphql-session-visibility-manager-compatibility branch November 26, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:i18n Localization area:ux UI / UX issue. size:M 30~100 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

compute_session_node Query requires project_id in manager < v24.12.0, causing session visibility issue
2 participants