Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FR-581): Add NEO vFolder list page #3232

Open
wants to merge 1 commit into
base: feat/NEO-quota-per-storage-volume-card
Choose a base branch
from

Conversation

agatha197
Copy link
Contributor

@agatha197 agatha197 commented Feb 21, 2025

resolves #3231 (FR-581)

Note

This PR doesn't handle delete/share/detail page. And pagination part will be refactored refer to #3245.

Implements a new NEO-style vFolder list page with enhanced UI/UX features:

  • Adds new folder management interface with status indicators and permission controls
  • Introduces action item content component for folder creation and file upload
  • Implements new table component for displaying folder information with sortable columns
  • Adds support for filtering folders by type (General, Pipeline, AutoMount, Models)
  • Includes folder status monitoring with color-coded tags
  • Adds mount permission display and management
  • Implements trash bin functionality for folder deletion
  • Adds multi-language support for all new UI elements

image.png

image.png

Checklist:

  • Documentation
  • Test case(s) to demonstrate the difference of before/after
    • Create new folder and verify status updates
    • Test folder filtering and sorting
    • Verify permission controls work correctly
    • Confirm trash bin operations function properly

@github-actions github-actions bot added area:ux UI / UX issue. area:i18n Localization size:XL 500~ LoC labels Feb 21, 2025
Copy link
Contributor Author

agatha197 commented Feb 21, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@agatha197 agatha197 force-pushed the feat/add-NEO-vFolder-list-page branch from 9494081 to 8d1708d Compare February 24, 2025 02:31
@agatha197 agatha197 force-pushed the feat/NEO-quota-per-storage-volume-card branch from cd98859 to 34e9355 Compare February 24, 2025 02:31
@agatha197 agatha197 force-pushed the feat/add-NEO-vFolder-list-page branch from 8d1708d to ab79530 Compare February 24, 2025 12:49
@agatha197 agatha197 force-pushed the feat/NEO-quota-per-storage-volume-card branch from 34e9355 to 6abcf54 Compare February 24, 2025 12:51
@agatha197 agatha197 force-pushed the feat/add-NEO-vFolder-list-page branch 3 times, most recently from c815a5a to dd5ba79 Compare February 24, 2025 12:55
@agatha197 agatha197 force-pushed the feat/NEO-quota-per-storage-volume-card branch from 6abcf54 to cc6c28b Compare February 24, 2025 12:55
@agatha197 agatha197 force-pushed the feat/add-NEO-vFolder-list-page branch 2 times, most recently from ec28401 to 6e4ea9a Compare February 24, 2025 13:12
@agatha197 agatha197 force-pushed the feat/NEO-quota-per-storage-volume-card branch 2 times, most recently from 4099790 to b8cee8f Compare February 24, 2025 13:14
@agatha197 agatha197 force-pushed the feat/add-NEO-vFolder-list-page branch 3 times, most recently from 4e1c900 to b4ecad3 Compare February 24, 2025 13:31
@agatha197 agatha197 force-pushed the feat/NEO-quota-per-storage-volume-card branch from b8cee8f to a6b2b23 Compare February 24, 2025 13:41
@agatha197 agatha197 force-pushed the feat/add-NEO-vFolder-list-page branch 4 times, most recently from 5cc56fa to 0f7ba5e Compare February 25, 2025 00:13
@agatha197 agatha197 force-pushed the feat/NEO-quota-per-storage-volume-card branch from a6b2b23 to 7c8af16 Compare February 25, 2025 00:13
@agatha197 agatha197 force-pushed the feat/add-NEO-vFolder-list-page branch from 0f7ba5e to 6b62c4c Compare February 25, 2025 00:23
@agatha197 agatha197 force-pushed the feat/NEO-quota-per-storage-volume-card branch from 7c8af16 to db7d7bd Compare February 25, 2025 00:24
@agatha197 agatha197 force-pushed the feat/NEO-quota-per-storage-volume-card branch from db7d7bd to feb6797 Compare February 26, 2025 05:43
@agatha197 agatha197 force-pushed the feat/add-NEO-vFolder-list-page branch 3 times, most recently from 16d961b to 2def78b Compare February 26, 2025 06:48
@agatha197 agatha197 requested a review from yomybaby February 26, 2025 06:48
Copy link
Contributor

@ironAiken2 ironAiken2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image.png

If the window size is reduced, the buttons will not show properly.

image.png

If there are no storage quota settings, the Empty component shown will land outside the parent.

image.png

When the table tab is moved, the existing search history of the property filter should be initialized.

@agatha197 agatha197 force-pushed the feat/NEO-quota-per-storage-volume-card branch from feb6797 to cdfd04b Compare February 26, 2025 13:14
@agatha197 agatha197 force-pushed the feat/add-NEO-vFolder-list-page branch from 2def78b to c52262c Compare February 26, 2025 13:14
@agatha197 agatha197 force-pushed the feat/NEO-quota-per-storage-volume-card branch from cdfd04b to 9c0eec3 Compare February 26, 2025 15:00
@agatha197 agatha197 force-pushed the feat/add-NEO-vFolder-list-page branch from c52262c to 5c29177 Compare February 26, 2025 15:00
@agatha197 agatha197 force-pushed the feat/add-NEO-vFolder-list-page branch from 5c29177 to 5c3523c Compare February 27, 2025 04:37
@agatha197 agatha197 force-pushed the feat/NEO-quota-per-storage-volume-card branch from 9c0eec3 to 16d6c55 Compare February 27, 2025 05:24
@agatha197 agatha197 force-pushed the feat/add-NEO-vFolder-list-page branch from 5c3523c to 24d473a Compare February 27, 2025 05:24
@ironAiken2 ironAiken2 force-pushed the feat/NEO-quota-per-storage-volume-card branch from 16d6c55 to 823b9f2 Compare February 27, 2025 05:39
@ironAiken2 ironAiken2 force-pushed the feat/add-NEO-vFolder-list-page branch 2 times, most recently from 371a8c9 to cfc26c4 Compare February 27, 2025 07:08
@ironAiken2 ironAiken2 force-pushed the feat/NEO-quota-per-storage-volume-card branch from 823b9f2 to ee41b09 Compare February 27, 2025 07:14
@ironAiken2 ironAiken2 force-pushed the feat/add-NEO-vFolder-list-page branch 2 times, most recently from dbc0aaa to b6ac543 Compare February 27, 2025 07:27
@ironAiken2 ironAiken2 force-pushed the feat/NEO-quota-per-storage-volume-card branch from ee41b09 to a70260b Compare February 27, 2025 11:01
@ironAiken2 ironAiken2 force-pushed the feat/add-NEO-vFolder-list-page branch from b6ac543 to c6ef33c Compare February 27, 2025 11:01
Copy link
Contributor

@ironAiken2 ironAiken2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:i18n Localization area:ux UI / UX issue. size:XL 500~ LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants