Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FR-592): NEO vfolder page - delete folders #3251

Open
wants to merge 1 commit into
base: feat/add-NEO-vFolder-list-page
Choose a base branch
from

Conversation

agatha197
Copy link
Contributor

@agatha197 agatha197 commented Feb 25, 2025

resolves #3248 (FR-592)

Implements trash bin functionality for virtual folders, allowing users to:

  • Move folders to trash with confirmation
  • Restore folders from trash
  • Permanently delete folders from trash with text confirmation
  • Handle multiple folder operations simultaneously

image.png

image.png

image.png

Checklist:

  • Documentation
  • Test case to verify trash bin operations (move/restore/delete)
  • Verify localization strings for all supported languages
  • Verify proper permission handling for trash operations

Copy link
Contributor Author

agatha197 commented Feb 25, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Member

@yomybaby yomybaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After a successful deletion, please reset the selected vfolder state.
Please check the snapshot below. After deletion, "2 items selected" remains.

image.png

@agatha197 agatha197 force-pushed the feat/add-NEO-vFolder-list-page branch from 9a2fb84 to 4efe445 Compare February 26, 2025 05:43
@agatha197 agatha197 force-pushed the feature_fr-592_/neo-vfolder-delete branch from 95a6c01 to d0b00b4 Compare February 26, 2025 05:43
@agatha197 agatha197 force-pushed the feat/add-NEO-vFolder-list-page branch from 4efe445 to 16d961b Compare February 26, 2025 06:04
@agatha197 agatha197 force-pushed the feature_fr-592_/neo-vfolder-delete branch from d0b00b4 to e1d0eb4 Compare February 26, 2025 06:04
@agatha197 agatha197 force-pushed the feat/add-NEO-vFolder-list-page branch from 16d961b to 2def78b Compare February 26, 2025 06:48
@agatha197 agatha197 force-pushed the feature_fr-592_/neo-vfolder-delete branch 3 times, most recently from 8a56805 to 8f74e83 Compare February 26, 2025 06:53
@agatha197 agatha197 requested a review from yomybaby February 26, 2025 06:53
@agatha197 agatha197 force-pushed the feature_fr-592_/neo-vfolder-delete branch from 8f74e83 to ddc48e4 Compare February 26, 2025 13:14
@agatha197 agatha197 force-pushed the feat/add-NEO-vFolder-list-page branch from 2def78b to c52262c Compare February 26, 2025 13:14
@agatha197 agatha197 force-pushed the feature_fr-592_/neo-vfolder-delete branch from ddc48e4 to d534972 Compare February 26, 2025 15:00
@agatha197 agatha197 force-pushed the feat/add-NEO-vFolder-list-page branch from 5c29177 to 5c3523c Compare February 27, 2025 04:37
@agatha197 agatha197 force-pushed the feature_fr-592_/neo-vfolder-delete branch from d534972 to 917f63c Compare February 27, 2025 04:37
@agatha197 agatha197 force-pushed the feature_fr-592_/neo-vfolder-delete branch from 917f63c to 3baabe1 Compare February 27, 2025 05:24
@agatha197 agatha197 force-pushed the feat/add-NEO-vFolder-list-page branch from 5c3523c to 24d473a Compare February 27, 2025 05:24
@ironAiken2 ironAiken2 force-pushed the feat/add-NEO-vFolder-list-page branch from 24d473a to 371a8c9 Compare February 27, 2025 05:39
@ironAiken2 ironAiken2 force-pushed the feature_fr-592_/neo-vfolder-delete branch 2 times, most recently from 865e414 to 50c5e61 Compare February 27, 2025 06:10
@ironAiken2 ironAiken2 requested a review from lizable February 27, 2025 06:11
@ironAiken2 ironAiken2 force-pushed the feat/add-NEO-vFolder-list-page branch from 371a8c9 to cfc26c4 Compare February 27, 2025 07:08
@ironAiken2 ironAiken2 force-pushed the feature_fr-592_/neo-vfolder-delete branch from 50c5e61 to 36c06ff Compare February 27, 2025 07:08
@ironAiken2 ironAiken2 force-pushed the feat/add-NEO-vFolder-list-page branch from cfc26c4 to dbc0aaa Compare February 27, 2025 07:14
@ironAiken2 ironAiken2 force-pushed the feature_fr-592_/neo-vfolder-delete branch from 36c06ff to 12f431d Compare February 27, 2025 07:14
@ironAiken2 ironAiken2 force-pushed the feat/add-NEO-vFolder-list-page branch from dbc0aaa to b6ac543 Compare February 27, 2025 07:27
@ironAiken2 ironAiken2 force-pushed the feature_fr-592_/neo-vfolder-delete branch from 12f431d to 62f3cf0 Compare February 27, 2025 07:28
@ironAiken2 ironAiken2 force-pushed the feat/add-NEO-vFolder-list-page branch from b6ac543 to c6ef33c Compare February 27, 2025 11:01
@ironAiken2 ironAiken2 force-pushed the feature_fr-592_/neo-vfolder-delete branch from 62f3cf0 to 1675301 Compare February 27, 2025 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:i18n Localization area:ux UI / UX issue. size:XL 500~ LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants