Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FR-533): Add fluent-emoji-flat component #3265

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

ragingwind
Copy link
Contributor

@ragingwind ragingwind commented Feb 26, 2025

resolves #3239 (FR-553)

  • Add FluentEmojiFlat Component to display fluent-emoji from json resource

@github-actions github-actions bot added the size:L 100~500 LoC label Feb 26, 2025
@ragingwind ragingwind marked this pull request as ready for review February 26, 2025 07:10
Copy link
Contributor Author

ragingwind commented Feb 26, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ragingwind ragingwind changed the base branch from 02-18-add_agents to graphite-base/3265 February 26, 2025 07:28
@yomybaby yomybaby changed the title use fluent-emoji-flat feat(FR-533): use fluent-emoji-flat Feb 26, 2025
Copy link
Member

@yomybaby yomybaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix lint error:

/Users/codejong/Workspace/lablup/webui/react/src/components/Chat/EndpointLLMChatCard.tsx
  14:17  warning  'Avatar' is defined but never used  @typescript-eslint/no-unused-vars

@ragingwind ragingwind force-pushed the 02-26-use_fluent-emoji-flat branch from a46103b to 58f9a92 Compare February 26, 2025 09:45
Copy link
Contributor Author

fixed

@ragingwind ragingwind changed the title feat(FR-533): use fluent-emoji-flat feat(FR-533): Add fluent-emoji-flat component Feb 26, 2025
@ragingwind ragingwind requested a review from yomybaby February 26, 2025 09:45
@yomybaby yomybaby force-pushed the 02-26-use_fluent-emoji-flat branch from 58f9a92 to ecc35e3 Compare February 27, 2025 05:04
Copy link
Member

@yomybaby yomybaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

graphite-app bot commented Feb 27, 2025

Merge activity

resolves #3239 (FR-553)

- Add FluentEmojiFlat Component to display fluent-emoji from json resource
@graphite-app graphite-app bot force-pushed the 02-26-use_fluent-emoji-flat branch from ecc35e3 to 545eba0 Compare February 27, 2025 05:08
@github-actions github-actions bot added area:ux UI / UX issue. area:i18n Localization size:XL 500~ LoC and removed size:L 100~500 LoC labels Feb 27, 2025
@graphite-app graphite-app bot changed the base branch from graphite-base/3265 to 02-18-add_agents February 27, 2025 05:08
Base automatically changed from 02-18-add_agents to main February 27, 2025 05:09
@graphite-app graphite-app bot merged commit 545eba0 into main Feb 27, 2025
4 checks passed
@graphite-app graphite-app bot deleted the 02-26-use_fluent-emoji-flat branch February 27, 2025 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:i18n Localization area:ux UI / UX issue. size:XL 500~ LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Agent Page to the WebUI
2 participants