Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Select to new Combobox component #593

Draft
wants to merge 137 commits into
base: main
Choose a base branch
from
Draft

Refactor Select to new Combobox component #593

wants to merge 137 commits into from

Conversation

CarlosBonetti
Copy link
Contributor

Due to the large number of issues for the Select component, I'm refactoring it to the new Combobox component.
This new Combobox component is built using the new useCombobox downshift hook instead of the <Downshift /> component Select currently uses.

The idea is to use extensive jest tests to cover all scenarios and currently open bugs.

This refactoring should address:

Migration

The Select component will be kept in the codebase allowing users to gradually change from Select to Combobox component.

@CarlosBonetti CarlosBonetti changed the title Start of Combobox component Refactor Select to new Combobox component Jul 26, 2020
@codecov
Copy link

codecov bot commented Jul 26, 2020 •
edited
Loading

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (66cce42) 98.71% compared to head (65f6cd4) 98.74%.
Report is 1 commits behind head on main.

❗ Current head 65f6cd4 differs from pull request most recent head 83bc0b2. Consider uploading reports for the commit 83bc0b2 to get more accurate results

Files Patch % Lines
src/components/Combobox/ComboboxMultiselect.tsx 94.78% 5 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #593      +/-   ##
==========================================
+ Coverage   98.71%   98.74%   +0.02%     
==========================================
  Files         525      535      +10     
  Lines        4452     4850     +398     
  Branches      687      782      +95     
==========================================
+ Hits         4395     4789     +394     
- Misses         57       60       +3     
- Partials        0        1       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Andrevmatias Andrevmatias linked an issue Dec 15, 2020 that may be closed by this pull request
Combobox - Select component refactoring #620
Open
21 tasks
@vercel vercel bot temporarily deployed to Preview December 16, 2020 19:18 Inactive
@vercel vercel bot temporarily deployed to Preview January 18, 2021 18:01 Inactive
@vercel vercel bot temporarily deployed to Preview February 5, 2021 19:59 Inactive
@vercel vercel bot temporarily deployed to Preview September 14, 2022 18:38 Inactive
@Andrevmatias
passing isOpen only when defined
4f8cf2b
@Andrevmatias
tests for the open property
717df37
@Andrevmatias
add popperProps to Combobox
b7ffe1e
@Andrevmatias
updating snapshots
ad8c84c
@Andrevmatias
Merge pull request #805 from laboratoriobridge/804-combobox-select-co…
4f4ee70 
…mpatibility

#804 - Combobox/Select compatibility
@Andrevmatias
removing support for createNewItem on Multiselect
ec23702
@Andrevmatias
removing unecessary acts
ce4d2b3
@Andrevmatias
amend
32ef53a
@Andrevmatias
migrating SingleSelect tests
ab35c38
@Andrevmatias
more SelectSingle tests
62d9617
@Andrevmatias
optimizing ComboboxMultiselect test
c1ee68d
@Andrevmatias
importing SelectMulti tests
7378a14
@Andrevmatias
combobox multiselect tests, singleselect adjustments and init inlines…
ba67784 
…elect tests
@Andrevmatias
importing SelectInline tests
189edde
@Andrevmatias
disabling combobox snapshot tests
a78810d
@Andrevmatias
Merge pull request #814 from laboratoriobridge/migrating-tests-from-s…
65f6cd4 
…elect

#812 - Migrating tests from select
@Andrevmatias
Merge branch 'main' into combobox
83bc0b2
@Andrevmatias
add toggle button to multiselect
a7771d7
@Andrevmatias
add clearFilterOnSelect
3340e10
@Andrevmatias
Merge branch 'main' into combobox
114cd14
@Andrevmatias
Merge branch 'combobox' into 823-combobox-treating-select-issues
09c30c0
@Andrevmatias
removing popup from tab order
3bb05f3
@Andrevmatias
tests for clearFilterOnSelect
7ffa763
@Andrevmatias
broken test adjustment
0152abb
@Andrevmatias
Merge pull request #853 from laboratoriobridge/823-combobox-treating-…
52b576d 
…select-issues

#823 [Combobox] - Treating select issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Combobox - Select component refactoring
3 participants
@CarlosBonetti @calistro @Andrevmatias