Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: launchpad rollingupdate #4279

Closed
wants to merge 1 commit into from
Closed

fix: launchpad rollingupdate #4279

wants to merge 1 commit into from

Conversation

c121914yu
Copy link
Collaborator

@c121914yu c121914yu commented Nov 9, 2023 •
edited by ghost
Loading

🤖 Generated by Copilot at 4b16261

Summary

🔄🚀🌐

Improve zero-downtime deployment strategy for applaunchpad provider. Change frontend/providers/applaunchpad/src/utils/deployYaml2Json.ts to use rollingUpdate with maxUnavailable: 0 and maxSurge: 1.

json2DeployCr
Zero-downtime rolling update -
Autumn leaves falling

Walkthrough

  • Modify the rollingUpdate strategy to use a zero-downtime approach for Kubernetes deployments (link)

@sweep-ai Sweep AI
Copy link

sweep-ai bot commented Nov 9, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.

@sealos-ci-robot
Copy link
Member

🤖 Generated by lychee action

Summary

Status Count
🔍 Total 981
✅ Successful 312
⏳ Timeouts 0
🔀 Redirected 0
👻 Excluded 668
❓ Unknown 0
🚫 Errors 0

Full action output

Full Github Actions output

@codecov Codecov
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@c121914yu c121914yu closed this Nov 9, 2023
@c121914yu c121914yu deleted the dev-yjl branch November 9, 2023 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zzjin zzjin zzjin approved these changes

Assignees
No one assigned
Labels
area/frontend size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@c121914yu @sealos-ci-robot @zzjin