Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i cant remove the backround #406

Open
hihibro10 opened this issue Jan 7, 2025 · 7 comments
Open

i cant remove the backround #406

hihibro10 opened this issue Jan 7, 2025 · 7 comments

Comments

@hihibro10
Copy link

hihibro10 commented Jan 7, 2025

hello i need help if i tap ,,cntl , alt , shift and x " it dont work to remove the backround

@pbogdan
Copy link

pbogdan commented Jan 9, 2025

Possible duplicate of #384?

I'm seeing this too occasionally (on Windows).

@lacymorrow
Copy link
Owner

Are you running any other programs that could potentially be using the same keyboard shortcut? Could you try sending a different keyboard shortcut?

@pbogdan
Copy link

pbogdan commented Jan 10, 2025

I don't think for me the issue is with a conflicting shortcut. I haven't tested this extensively but it seems that the issue occurs after whenever I open the settings (bottom right cog icon on the overlay).
So for example when I first start the app the shortcut works fine and I can keep toggling the background on/off. As soon as I open the settings and close them the shortcut stops working.

@lacymorrow
Copy link
Owner

Hands-down, best bug report I've had all year!

I disable certain keyboard shortcuts when the settings window� is open, there's a good chance they aren't getting reset properly

@pbogdan
Copy link

pbogdan commented Jan 10, 2025

Thanks!

BTW I don't know if it's relevant but running with --debug show the following errors:

  • upon opening the settings dialog

    TypeError: windows.preferencesWindow.webContents.setWindowOpenHandler is not a function
    at Object.openSettingsWindow 
    (C:\Users\ppbog\AppData\Local\Programs\crossover\resources\app.asar\src\main\crossover.js:532:41)
    at IpcMainImpl.<anonymous> 
    (C:\Users\ppbog\AppData\Local\Programs\crossover\resources\app.asar\src\main\ipc.js:77:13)
    at IpcMainImpl.emit (events.js:315:20)
    at Object.<anonymous> (electron/js2c/browser_init.js:157:9051)
    at Object.emit (events.js:315:20)
    
  • once the settings window has been closed invoking the shortcut produces the following:

    TypeError: Object has been destroyed
    at Object.hideSettingsWindow (C:\Users\ppbog\AppData\Local\Programs\crossover\resources\app.asar\src\main\windows.js:335:62)
    at lockWindow (C:\Users\ppbog\AppData\Local\Programs\crossover\resources\app.asar\src\main\crossover.js:209:10)
    at Object.<anonymous> (C:\Users\ppbog\AppData\Local\Programs\crossover\resources\app.asar\src\main\crossover.js:577:25)
    at Object.each (C:\Users\ppbog\AppData\Local\Programs\crossover\resources\app.asar\src\main\windows.js:54:5)
    at Object.toggleWindowLock (C:\Users\ppbog\AppData\Local\Programs\crossover\resources\app.asar\src\main\crossover.js:577:10)
    at Function.fn (C:\Users\ppbog\AppData\Local\Programs\crossover\resources\app.asar\src\main\crossover.js:48:15)
    

@lacymorrow
Copy link
Owner

oh yeah, that helps a ton, that is a direct error from electron. In windows, closing the settings window destroys the browser window object, and I have to re-create it on the fly. This error displays because I'm trying to hide a browser window that doesn't exist.

Thanks dude, that really makes my life a little easier.

@pbogdan
Copy link

pbogdan commented Jan 10, 2025

You are welcome, glad I could help :-).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants