Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement pore-centered PH featurizer #70

Open
kjappelbaum opened this issue May 9, 2022 · 2 comments
Open

implement pore-centered PH featurizer #70

kjappelbaum opened this issue May 9, 2022 · 2 comments
Assignees

Comments

@kjappelbaum
Copy link
Collaborator

kjappelbaum commented May 9, 2022

in principle, this shouldn't be too hard:

  1. We get the atoms that form the pore(s) - atm, not so clear if, for instance, zeo++ could directly return this
  2. If needed, we unfold the PBC - challenge here is, of course that for channels we could replicate forever. But to get a signal, one full periodic replica should be enough
  3. Then run the TDA
@kjappelbaum kjappelbaum added the enhancement New feature or request label May 9, 2022
@kjappelbaum kjappelbaum self-assigned this May 9, 2022
@kjappelbaum
Copy link
Collaborator Author

This would be a pretty interesting featurizer. Already just having the atoms on the "surface" of a pore in Python would allow us to do many interesting things.

Would you be interested @sauradeep93 ?

@sauradeep93
Copy link

Hi, Yes I would be interested !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants