Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document public api #1278

Closed
wants to merge 8 commits into from
Closed

Document public api #1278

wants to merge 8 commits into from

Conversation

fmoletta
Copy link
Contributor

TITLE

Description

Description of the pull request changes and motivation.

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

@fmoletta fmoletta linked an issue Jun 23, 2023 that may be closed by this pull request
Document cairo-rs API #1234
Open
@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Merging #1278 (b428f33) into main (d332207) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1278      +/-   ##
==========================================
- Coverage   97.61%   97.60%   -0.01%     
==========================================
  Files          89       89              
  Lines       36333    36335       +2     
==========================================
  Hits        35466    35466              
- Misses        867      869       +2
Impacted Files Coverage Δ
vm/src/vm/runners/cairo_runner.rs 98.04% <ø> (ø)
vm/src/vm/vm_memory/memory_segments.rs 98.98% <ø> (ø)
vm/src/vm/context/run_context.rs 99.71% <100.00%> (ø)
vm/src/vm/decoding/decoder.rs 100.00% <100.00%> (ø)
vm/src/vm/vm_core.rs 97.81% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fmoletta fmoletta closed this May 29, 2024
@juanbono
Copy link
Collaborator

Kill it with fire!!

@fmoletta fmoletta deleted the add-doc branch May 29, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igaray igaray Awaiting requested review from igaray igaray will be requested when the pull request is marked ready for review igaray is a code owner

@Oppen Oppen Awaiting requested review from Oppen Oppen will be requested when the pull request is marked ready for review Oppen is a code owner

@juanbono juanbono Awaiting requested review from juanbono juanbono will be requested when the pull request is marked ready for review juanbono is a code owner

@pefontana pefontana Awaiting requested review from pefontana pefontana will be requested when the pull request is marked ready for review pefontana is a code owner

@gabrielbosio gabrielbosio Awaiting requested review from gabrielbosio gabrielbosio will be requested when the pull request is marked ready for review gabrielbosio is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document cairo-rs API
2 participants
@fmoletta @juanbono