Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make arrays shared cow v2 #897

Open
wants to merge 34 commits into
base: main
Choose a base branch
from
Open

Make arrays shared cow v2 #897

wants to merge 34 commits into from

Conversation

azteca1998
Copy link
Collaborator

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.

Copy link

github-actions bot commented Nov 4, 2024

Benchmarking results

Benchmark for program factorial_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 11.779 ± 0.285 11.074 12.178 8.75 ± 0.21
cairo-native (embedded AOT) 3.428 ± 0.026 3.389 3.479 2.54 ± 0.02
cairo-native (embedded JIT using LLVM's ORC Engine) 3.240 ± 0.026 3.186 3.270 2.41 ± 0.02
cairo-native (standalone AOT with -march=native) 1.347 ± 0.001 1.345 1.349 1.00

Benchmark for program fib_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 11.650 ± 0.321 11.297 12.117 148.91 ± 4.11
cairo-native (embedded AOT) 3.161 ± 0.039 3.086 3.211 40.41 ± 0.50
cairo-native (embedded JIT using LLVM's ORC Engine) 2.937 ± 0.036 2.875 2.980 37.55 ± 0.46
cairo-native (standalone AOT with -march=native) 0.078 ± 0.000 0.078 0.079 1.00

Benchmark for program logistic_map

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 4.274 ± 0.035 4.229 4.319 17.55 ± 0.14
cairo-native (embedded AOT) 3.143 ± 0.044 3.098 3.232 12.91 ± 0.18
cairo-native (embedded JIT using LLVM's ORC Engine) 3.019 ± 0.032 2.979 3.078 12.40 ± 0.13
cairo-native (standalone AOT with -march=native) 0.243 ± 0.000 0.243 0.244 1.00

Copy link

github-actions bot commented Nov 4, 2024

Benchmark results Main vs HEAD.

Command Mean [s] Min [s] Max [s] Relative
base factorial_2M.cairo (JIT) 3.268 ± 0.031 3.212 3.305 1.00
base factorial_2M.cairo (AOT) 3.504 ± 0.024 3.471 3.544 1.07 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
:--- ---: ---: ---: ---:
head factorial_2M.cairo (JIT) 3.243 ± 0.031 3.204 3.287 1.00
head factorial_2M.cairo (AOT) 3.526 ± 0.036 3.459 3.588 1.09 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base fib_2M.cairo (JIT) 2.860 ± 0.046 2.750 2.918 1.00
base fib_2M.cairo (AOT) 2.955 ± 0.016 2.917 2.976 1.03 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
:--- ---: ---: ---: ---:
head fib_2M.cairo (JIT) 2.864 ± 0.030 2.820 2.910 1.00
head fib_2M.cairo (AOT) 3.008 ± 0.031 2.957 3.050 1.05 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base logistic_map.cairo (JIT) 3.069 ± 0.026 3.039 3.109 1.00
base logistic_map.cairo (AOT) 3.116 ± 0.016 3.091 3.133 1.02 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
:--- ---: ---: ---: ---:
head logistic_map.cairo (JIT) 3.095 ± 0.039 3.056 3.150 1.00
head logistic_map.cairo (AOT) 3.163 ± 0.018 3.123 3.190 1.02 ± 0.01

@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 88.41808% with 41 lines in your changes missing coverage. Please review.

Project coverage is 82.44%. Comparing base (2bad480) to head (5bde1df).

Files with missing lines Patch % Lines
src/starknet.rs 44.11% 19 Missing ⚠️
src/executor/contract.rs 79.41% 7 Missing ⚠️
src/values.rs 92.50% 6 Missing ⚠️
src/types/array.rs 97.84% 4 Missing ⚠️
src/libfuncs.rs 0.00% 3 Missing ⚠️
src/executor.rs 77.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #897      +/-   ##
==========================================
- Coverage   82.54%   82.44%   -0.10%     
==========================================
  Files         117      117              
  Lines       33516    34071     +555     
==========================================
+ Hits        27666    28091     +425     
- Misses       5850     5980     +130     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

edg-l
edg-l previously approved these changes Nov 27, 2024
src/libfuncs/array.rs Outdated Show resolved Hide resolved
@edg-l edg-l added the review-ready A PR that is ready for review label Nov 27, 2024
edg-l
edg-l previously approved these changes Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review-ready A PR that is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants