-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix env.sh
.
#944
Merged
Merged
Fix env.sh
.
#944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azteca1998
requested review from
edg-l,
igaray,
jrchatruc,
entropidelic,
fmoletta,
Oppen,
pefontana and
gabrielbosio
as code owners
November 27, 2024 15:03
FrancoGiachetta
approved these changes
Nov 27, 2024
Benchmarking resultsBenchmark for program
|
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
11.547 ± 0.362 | 10.969 | 11.900 | 8.56 ± 0.27 |
cairo-native (embedded AOT) |
3.567 ± 0.067 | 3.500 | 3.724 | 2.65 ± 0.05 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
3.353 ± 0.054 | 3.274 | 3.434 | 2.49 ± 0.04 |
cairo-native (standalone AOT with -march=native) |
1.348 ± 0.001 | 1.347 | 1.350 | 1.00 |
Benchmark for program fib_2M
Open benchmarks
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
11.150 ± 0.259 | 10.803 | 11.687 | 142.02 ± 4.54 |
cairo-native (embedded AOT) |
3.114 ± 0.042 | 3.066 | 3.193 | 39.66 ± 1.02 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
2.886 ± 0.045 | 2.812 | 2.964 | 36.76 ± 0.99 |
cairo-native (standalone AOT with -march=native) |
0.079 ± 0.002 | 0.078 | 0.089 | 1.00 |
Benchmark for program logistic_map
Open benchmarks
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
4.483 ± 0.034 | 4.423 | 4.535 | 18.50 ± 0.14 |
cairo-native (embedded AOT) |
3.321 ± 0.024 | 3.278 | 3.366 | 13.70 ± 0.10 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
3.277 ± 0.045 | 3.205 | 3.353 | 13.52 ± 0.19 |
cairo-native (standalone AOT with -march=native) |
0.242 ± 0.000 | 0.242 | 0.243 | 1.00 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #944 +/- ##
==========================================
- Coverage 82.55% 82.54% -0.02%
==========================================
Files 117 117
Lines 33505 33516 +11
==========================================
+ Hits 27661 27666 +5
- Misses 5844 5850 +6 ☔ View full report in Codecov by Sentry. |
Benchmark results Main vs HEAD.
|
gabrielbosio
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows
env.sh
to be used from any directory, not just the cairo native project's root. This is useful for setting up the environment in other projects (ex. the replay) painlessly.Checklist