Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix env.sh. #944

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Fix env.sh. #944

merged 1 commit into from
Nov 27, 2024

Conversation

azteca1998
Copy link
Collaborator

This PR allows env.sh to be used from any directory, not just the cairo native project's root. This is useful for setting up the environment in other projects (ex. the replay) painlessly.

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.

Copy link

Benchmarking results

Benchmark for program factorial_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 11.547 ± 0.362 10.969 11.900 8.56 ± 0.27
cairo-native (embedded AOT) 3.567 ± 0.067 3.500 3.724 2.65 ± 0.05
cairo-native (embedded JIT using LLVM's ORC Engine) 3.353 ± 0.054 3.274 3.434 2.49 ± 0.04
cairo-native (standalone AOT with -march=native) 1.348 ± 0.001 1.347 1.350 1.00

Benchmark for program fib_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 11.150 ± 0.259 10.803 11.687 142.02 ± 4.54
cairo-native (embedded AOT) 3.114 ± 0.042 3.066 3.193 39.66 ± 1.02
cairo-native (embedded JIT using LLVM's ORC Engine) 2.886 ± 0.045 2.812 2.964 36.76 ± 0.99
cairo-native (standalone AOT with -march=native) 0.079 ± 0.002 0.078 0.089 1.00

Benchmark for program logistic_map

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 4.483 ± 0.034 4.423 4.535 18.50 ± 0.14
cairo-native (embedded AOT) 3.321 ± 0.024 3.278 3.366 13.70 ± 0.10
cairo-native (embedded JIT using LLVM's ORC Engine) 3.277 ± 0.045 3.205 3.353 13.52 ± 0.19
cairo-native (standalone AOT with -march=native) 0.242 ± 0.000 0.242 0.243 1.00

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.54%. Comparing base (76e8396) to head (34416b8).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #944      +/-   ##
==========================================
- Coverage   82.55%   82.54%   -0.02%     
==========================================
  Files         117      117              
  Lines       33505    33516      +11     
==========================================
+ Hits        27661    27666       +5     
- Misses       5844     5850       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Benchmark results Main vs HEAD.

Command Mean [s] Min [s] Max [s] Relative
base factorial_2M.cairo (JIT) 3.304 ± 0.040 3.224 3.364 1.00
base factorial_2M.cairo (AOT) 3.444 ± 0.033 3.406 3.508 1.04 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
:--- ---: ---: ---: ---:
head factorial_2M.cairo (JIT) 3.197 ± 0.021 3.165 3.239 1.00
head factorial_2M.cairo (AOT) 3.417 ± 0.031 3.377 3.479 1.07 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base fib_2M.cairo (JIT) 2.826 ± 0.033 2.770 2.882 1.00
base fib_2M.cairo (AOT) 3.065 ± 0.036 3.025 3.131 1.08 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
:--- ---: ---: ---: ---:
head fib_2M.cairo (JIT) 2.818 ± 0.046 2.758 2.886 1.00
head fib_2M.cairo (AOT) 3.077 ± 0.027 3.039 3.117 1.09 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base logistic_map.cairo (JIT) 3.163 ± 0.035 3.114 3.217 1.00
base logistic_map.cairo (AOT) 3.173 ± 0.035 3.123 3.230 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
:--- ---: ---: ---: ---:
head logistic_map.cairo (JIT) 3.262 ± 0.027 3.215 3.310 1.00 ± 0.02
head logistic_map.cairo (AOT) 3.257 ± 0.049 3.195 3.353 1.00

@gabrielbosio gabrielbosio added this pull request to the merge queue Nov 27, 2024
Merged via the queue into main with commit 2bad480 Nov 27, 2024
32 checks passed
@gabrielbosio gabrielbosio deleted the fix-env-script branch November 27, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants