Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cairo 2.9.1 and rust 1.83.0 #948

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Cairo 2.9.1 and rust 1.83.0 #948

wants to merge 5 commits into from

Conversation

edg-l
Copy link
Collaborator

@edg-l edg-l commented Nov 28, 2024

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.

Copy link

github-actions bot commented Nov 28, 2024

Benchmarking results

Benchmark for program factorial_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 14.206 ± 0.204 14.028 14.607 10.55 ± 0.15
cairo-native (embedded AOT) 4.155 ± 0.012 4.131 4.175 3.09 ± 0.01
cairo-native (embedded JIT using LLVM's ORC Engine) 3.961 ± 0.019 3.941 4.005 2.94 ± 0.01
cairo-native (standalone AOT with -march=native) 1.346 ± 0.001 1.345 1.349 1.00

Benchmark for program fib_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 13.860 ± 0.129 13.704 14.193 178.57 ± 1.70
cairo-native (embedded AOT) 3.727 ± 0.028 3.678 3.758 48.01 ± 0.37
cairo-native (embedded JIT using LLVM's ORC Engine) 3.532 ± 0.022 3.484 3.568 45.51 ± 0.30
cairo-native (standalone AOT with -march=native) 0.078 ± 0.000 0.077 0.078 1.00

Benchmark for program logistic_map

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 5.511 ± 0.026 5.470 5.553 22.78 ± 0.11
cairo-native (embedded AOT) 3.880 ± 0.020 3.861 3.908 16.04 ± 0.08
cairo-native (embedded JIT using LLVM's ORC Engine) 3.794 ± 0.029 3.751 3.841 15.69 ± 0.12
cairo-native (standalone AOT with -march=native) 0.242 ± 0.000 0.242 0.242 1.00

Copy link

github-actions bot commented Nov 28, 2024

Benchmark results Main vs HEAD.

Command Mean [s] Min [s] Max [s] Relative
base factorial_2M.cairo (JIT) 3.239 ± 0.027 3.204 3.281 1.00
base factorial_2M.cairo (AOT) 3.391 ± 0.060 3.342 3.543 1.05 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
:--- ---: ---: ---: ---:
head factorial_2M.cairo (JIT) 3.942 ± 0.023 3.907 3.970 1.00
head factorial_2M.cairo (AOT) 4.120 ± 0.016 4.099 4.143 1.05 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base fib_2M.cairo (JIT) 2.749 ± 0.041 2.695 2.844 1.00
base fib_2M.cairo (AOT) 2.987 ± 0.049 2.927 3.082 1.09 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
:--- ---: ---: ---: ---:
head fib_2M.cairo (JIT) 3.484 ± 0.019 3.453 3.512 1.00
head fib_2M.cairo (AOT) 3.681 ± 0.016 3.652 3.699 1.06 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base logistic_map.cairo (JIT) 3.059 ± 0.033 3.019 3.123 1.00
base logistic_map.cairo (AOT) 3.136 ± 0.034 3.114 3.229 1.03 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
:--- ---: ---: ---: ---:
head logistic_map.cairo (JIT) 3.780 ± 0.019 3.746 3.806 1.00
head logistic_map.cairo (AOT) 3.853 ± 0.030 3.816 3.924 1.02 ± 0.01

@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.54%. Comparing base (2bad480) to head (7d0951f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #948   +/-   ##
=======================================
  Coverage   82.54%   82.54%           
=======================================
  Files         117      117           
  Lines       33516    33516           
=======================================
  Hits        27666    27666           
  Misses       5850     5850           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

azteca1998
azteca1998 previously approved these changes Nov 28, 2024
tests/common.rs Show resolved Hide resolved
@edg-l edg-l changed the title Cairo 2.9.0 and rust 1.83.0 Cairo 2.9.1 and rust 1.83.0 Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants