fix(levm): logx non-compliance memory allocation (#1330)

Resolves #1323
lambdaclass · Nov 28, 2024 · 57e7311 · 57e7311
1 parent 37daa66
commit 57e7311
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/crates/vm/levm/src/memory.rs b/crates/vm/levm/src/memory.rs
@@ -66,6 +66,10 @@ impl Memory {
     }
 
     pub fn load_range(&mut self, offset: usize, size: usize) -> Result<Vec<u8>, VMError> {
+        if size == 0 {
+            return Ok(Vec::new());
+        }
+
         let size_to_load = offset.checked_add(size).ok_or(VMError::Internal(
             InternalError::ArithmeticOperationOverflow,
         ))?;

diff --git a/crates/vm/levm/tests/edge_case_tests.rs b/crates/vm/levm/tests/edge_case_tests.rs
@@ -251,3 +251,14 @@ fn test_non_compliance_extcodecopy_size_and_destoffset() {
         &U256::from(64)
     );
 }
+
+#[test]
+fn test_non_compliance_log() {
+    let mut vm = new_vm_with_bytecode(Bytes::copy_from_slice(&[95, 97, 89, 0, 160, 89])).unwrap();
+    let mut current_call_frame = vm.call_frames.pop().unwrap();
+    vm.execute(&mut current_call_frame);
+    assert_eq!(
+        current_call_frame.stack.stack.first().unwrap(),
+        &U256::zero()
+    );
+}