-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
L2: handle unwraps
in prover_server.rs
#1168
Labels
Comments
Is this still open? |
Yes, but we are working on this. It is becoming more complex than just handling the unwraps. Thanks for your interest in helping! |
github-merge-queue bot
pushed a commit
that referenced
this issue
Nov 26, 2024
**Motivation** The error handling should be the same for all processes, unwraps have to be handled with the `?` operator so that the api can restart the process if any `Err` is raised. **Description** - Use the same API proposed by the PR #1230, removing the unwraps. - #1168 - When we have an error we "restart" the process, this handles the `not committed block` error. - #1165 - The order of the require statements in the `verify()` function of the `OnChainProposer` contract was changed to throw the correct error. The error handling with the proposed API does the rest. - #1164. Closes #1168 Closes #1165 Closes #1164 --------- Co-authored-by: Javier Chatruc <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Handle unwraps in
prover_server.rs
we may want to handle unwraps inprover_client.rs
and even globally.The text was updated successfully, but these errors were encountered: