Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return proper Disconnect reasons #1214

Open
ElFantasma opened this issue Nov 19, 2024 · 0 comments
Open

Return proper Disconnect reasons #1214

ElFantasma opened this issue Nov 19, 2024 · 0 comments
Labels
network Issues related to network communication
Milestone
[L1] 4 - P2P Network

Comments

@ElFantasma
Copy link
Contributor

On p2p message Disconnect we should return a disconnect reason from the spec

We need to provide meaningful errors on all our p2p layer to be able to convert the error into a proper disconnect reason.
@ElFantasma ElFantasma added the network Issues related to network communication label Nov 19, 2024
@ElFantasma ElFantasma added this to the [L1] 4 - P2P Network milestone Nov 19, 2024
@ElFantasma ElFantasma mentioned this issue Nov 19, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Nov 20, 2024
@ElFantasma
feat(l1): implement status validation (#1194)
5de81ed 
**Motivation**

`eth/status` hive tests check proper handling of Status message and a
malicious Status message.

**Description**

- `eth/status` tests now are enabled and passes
- Added a check on RLPDecoding to prevent an error that panicked
- Now sending a `Disconnect` message on error

Closes #420 

Pending:
- Created a
[ticket](#1214)
to return proper disconnect reasons depending on the returned
`RLPxError`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
network Issues related to network communication
Projects
ethrex_l1
Status: No status
Milestone
[L1] 4 - P2P Network
Development

No branches or pull requests
1 participant
@ElFantasma