Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(levm): add memory alignment in extcodecopy #1263

Merged
merged 7 commits into from
Nov 25, 2024

Conversation

maximopalopoli
Copy link
Contributor

Motivation

Fixes an implementation error found by FuzzingLabs in extcodecopy opcode implementation.

Description

Previously, in EXTCODECOPY the allocated memory size was not aligned to a multiple of 32 bytes, and was added in, for example, 12 bytes (should increase in blocks of 32). Now the increases are done in groups of 32.

Closes #1251

@maximopalopoli maximopalopoli added the levm Lambda EVM implementation label Nov 25, 2024
@maximopalopoli maximopalopoli self-assigned this Nov 25, 2024
@maximopalopoli maximopalopoli marked this pull request as ready for review November 25, 2024 18:26
@maximopalopoli maximopalopoli requested a review from a team as a code owner November 25, 2024 18:26
@ilitteri ilitteri added this pull request to the merge queue Nov 25, 2024
Merged via the queue into main with commit ec09fed Nov 25, 2024
22 checks passed
@ilitteri ilitteri deleted the levm/fix/memory-alignment-extcodecopy branch November 25, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
levm Lambda EVM implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SECURITY] Non-Compliance : Memory Alignment in EXTCODECOPY Operation
2 participants