Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L2: Forbid panics #1269

Open
ilitteri opened this issue Nov 25, 2024 · 1 comment
Open

L2: Forbid panics #1269

ilitteri opened this issue Nov 25, 2024 · 1 comment
Labels

Comments

@ilitteri
Copy link
Contributor

ilitteri commented Nov 25, 2024

Add the following clippy lint to all Cargo.toml files in the l2 crate:

[lints.clippy]
panic = "deny"

and remove the panics of the module if necessary.

@varun-doshi
Copy link

varun-doshi commented Nov 26, 2024

I can take this up.
To clarify, this would make panic throw compile time errors so that we'd have to return a proper error.
I see some functions do not have a return type. Should I add a return type of Result<(),Error> there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

No branches or pull requests

2 participants