-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(l1): made the tx-spammer work with our node #1027
Conversation
…tosis-initial-params
… related to gas limit
…n unwrap due to a filtering condition not covered
Some other errors spotted but not resolved nonce 0 too low: Error on tx_spammer: But hitting the {
"id": 1,
"jsonrpc": "2.0",
"result": "0xf0"
} EOF: Error on tx_spammer: Logs shows an issue with an overflow outside of u64
This happens here in some particular transactions: if self.transaction.gas_price != 0 {
highest_gas_limit = recap_with_account_balances(
highest_gas_limit,
&self.transaction,
&storage,
block_header.number,
)?;
} |
- 'https://raw.githubusercontent.com/lambdaclass/lambda_ethereum_rust/refs/heads/main/test_data/el-stability-check.yml' | ||
tx_spammer_params: | ||
tx_spammer_extra_args: ["--accounts=10", --txcount=10] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these parameters are based on our current capabilities?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really, this is mostly to be able to track the execution instead of having hundreds of transactions (Which by the way we still need to check why we just add one as shown in the image). Most of the initial issues regarding the node being unable to propose weren't related to concurrency as I initially thought but to the errors mentioned in the PR description.
**Motivation** Have the tx spammer running instead of immediatly shutting down when we are the first node in the devnet setup. **Description** This PR tackled a couple of issues until we were able to process an initial transaction, (they are small changes): - We were returning an error on `eth_getTransactionCount` when we either didn't have a `latest` block before genesis or at any point when we don't have `pending` blocks. The solution in this case was returning `0x0` in those cases. - When requesting `eth_getTransactionCount` on `pending` after some transaction went through we were defaulting to `0x0`, it appears that the idea is to default to the `latest` in those case which make sense. - There were a missing filter that made the node panic when building payloads for transactions with fees lower than the base_fee_per_gas, this generated that those kind of transactions stopped the node's ability to build blocks when they were in the mempool, we made a quick workaround in this PR, but will remove it in favor of lambdaclass#1018 Closes lambdaclass#1026
Motivation
Have the tx spammer running instead of immediatly shutting down when we are the first node in the devnet setup.
Description
This PR tackled a couple of issues until we were able to process an initial transaction, (they are small changes):
eth_getTransactionCount
when we either didn't have alatest
block before genesis or at any point when we don't havepending
blocks. The solution in this case was returning0x0
in those cases.eth_getTransactionCount
onpending
after some transaction went through we were defaulting to0x0
, it appears that the idea is to default to thelatest
in those case which make sense.Closes #1026