-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(l2): initial state pruned trie in zkVM program #1133
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 19, 2024
**Motivation** The function does not return any account update when the state is represented by an `ExecutionDB`. Needed for #1133 **Description** - correctly implements the fn
fborello-lambda
approved these changes
Nov 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, left 1 comment
fmoletta
reviewed
Nov 19, 2024
fmoletta
reviewed
Nov 19, 2024
This reverts commit 36ea2f3.
jrchatruc
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To validate the initial and final state values after the execution of a block in the prover, we introduce state and storage tries into the zkVM program to verify the initial values and then to apply account updates and compute the new state hash.
Description
ProgramInput
(because the zkvm program fails to build when importing theprover
crate)ProgramOutput
alsoNullDB
database for tries (tries whose nodes are cached)from_nodes()
,get_pruned_state()
,build_tries()
,update_tries()
and use them when creating theExecutionDB
and in the zkVM program)