Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(levm): fix execution of eftests #1169

Draft
wants to merge 51 commits into
base: main
Choose a base branch
from
Draft

fix(levm): fix execution of eftests #1169

wants to merge 51 commits into from

Conversation

JereSalo
Copy link
Contributor

@JereSalo JereSalo commented Nov 14, 2024 •
edited
Loading

Motivation

  • When trying to execute some eftests we have some unexpected errors. That shouldn't happen on the execution. At least it should execute without errors and after that we will be able to check if the POST state is correct or not.

Description

Warning

  • This PR is going to be divided into multiple PRs, I will close and delete this branch when all the changes that it brings are not useful anymore

Closes #issue_number

@JereSalo JereSalo added the levm Lambda EVM implementation label Nov 14, 2024
@JereSalo JereSalo self-assigned this Nov 14, 2024
JereSalo and others added 27 commits November 14, 2024 11:56
@JereSalo
change return type of execute function
1588136
@JereSalo
propagate internal errors in execute()
a1cc72d
@JereSalo
uncomment particular test
edbcf91
@JereSalo
remove initial gas for env in transact()
b260fac
@JereSalo
remove duplicate initial_call_frame
30d82cf
@JereSalo
start with transact refactor
e7992f6
@JereSalo
propagate adequate errors in validate_transaction
952174b
@JereSalo
make some changes in transact and validations
7707224
@JereSalo
change add_gas_with_max of report
704eec6
@JereSalo
add '?' to add_gas_with_max
4f52377
@JereSalo
make changes in gas consumption, intrinsic gas
33c5fca
@JereSalo
add some todos
fb6684f
@JereSalo
add early validations
4c2479c
@JereSalo
add intrinsic gas validation
5d2eae2
@JereSalo
add some relevante fields to environment
1a57c89
@JereSalo
add more validations
1512f35
@JereSalo
fix some tests
fec5343
@JereSalo
fix intrinsic gas test
7bff0c1
@JereSalo
make minor changes
f810b6b
@JereSalo
make little change in execute_tx_levm
6285a25
@JereSalo
merge main into fixing_ef_tests_execution
5ce9714
@maximopalopoli
Handle all post states instead of taking first
86c9c2e
@maximopalopoli
fmt changes
5352e7b
@JereSalo
Merge branch 'levm/fix/handle-all-post-states' into levm/fixing_ef_te…
4310222 
…sts_execution
@JereSalo
add comments and organise validate_transaction
92d3f6b
@maximopalopoli
Aviod printing twice the report
2deff65
@maximopalopoli
Fetch the correct post state from tuple of indexes
827d9bf
maximopalopoli and others added 23 commits November 20, 2024 16:18
@maximopalopoli
Merge branch 'main' into levm/fix/handle-all-post-states
c488efe
@JereSalo
merge handle_all_post_states
d844d92
@JereSalo
fix failing test of InsufficientMaxFeePerGas
926e9c0
@JereSalo
fix error in return
d33f82a
@JereSalo
fix error with revert
a8a39bd
@JereSalo
comment debugging stuff
6288388
@maximopalopoli
Change bytes assignment in extcodecopy
6b34d91
@maximopalopoli
Fix clippy alerts about unexpected side effects
753f00f
@maximopalopoli
Prevent overflows in intrinsic gas cost calc
eb337c4
@maximopalopoli
Fix an alert from benchmarks
0847204
@JereSalo
fix failing unit tests (they were adding TX_BASE_COST for gas calcula…
09cd80b 
…tions)
@JereSalo
remove vectors folder
79b3d73
@JereSalo
make little adjustments
12ece12
@JereSalo
change some OutOfGas for VeryLargeNumber in some opcodes
1601505
@JereSalo
replace some internal errors for VeryLargeNumber
819ff65
@JereSalo
add type 3 validations
97efbe1
@JereSalo
add constant of VALID_BLOB_PREFIXES for versioned blob hashes
52bcc2c
@JereSalo
make little fix
3738159
@JereSalo
make some comments (every test executes properly now, except some tes…
38928e7 
…ts in Pyspecs)
@JereSalo
remove comment
616f207
@maximopalopoli
feat(levm): ensure returned errors are correct (#1225)
55517d5 
**Motivation**

Currently in EF tests we don't verify that the error returned by levm
matches with the expected, the goal is to verify it, and print an error
if it does not match.

**Description**

This PR includes:
- The logic of verifying the exception is the expected, in
`exception_is_expected()`
- The print of the error (or errors) that the EVM may throw in case the
error does not match or in case it does not return an error and one is
expected.
@JereSalo
feat(levm): improve revert behavior and reorganize transact (#1231)
c9058f8 
**Motivation**

<!-- Why does this pull request exist? What are its goals? -->

**Description**

<!-- A clear and concise general description of the changes this PR
introduces -->
- Organize transact
- Fix errors
- Improve reversion behavior
<!-- Link to issues: Resolves #111, Resolves #222 -->

Closes #issue_number
@JereSalo
uncomment 'running test'
2d1568b
@JereSalo JereSalo marked this pull request as ready for review November 25, 2024 14:10
@JereSalo JereSalo requested a review from a team as a code owner November 25, 2024 14:11
@JereSalo JereSalo marked this pull request as draft November 28, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@JereSalo JereSalo

Labels
levm Lambda EVM implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JereSalo @maximopalopoli