feat(l2): refactor processes to handle errors at the top and use a common api #1230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 26, 2024
**Motivation** The error handling should be the same for all processes, unwraps have to be handled with the `?` operator so that the api can restart the process if any `Err` is raised. **Description** - Use the same API proposed by the PR #1230, removing the unwraps. - #1168 - When we have an error we "restart" the process, this handles the `not committed block` error. - #1165 - The order of the require statements in the `verify()` function of the `OnChainProposer` contract was changed to throw the correct error. The error handling with the proposed API does the rest. - #1164. Closes #1168 Closes #1165 Closes #1164 --------- Co-authored-by: Javier Chatruc <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Description