Fix clippy, remove partial ord from babybear (#591)

lambdaclass · Oct 5, 2023 · bea1b8d · bea1b8d
1 parent f050c5c
commit bea1b8d
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 12 deletions.
diff --git a/math/src/field/fields/fft_friendly/babybear.rs b/math/src/field/fields/fft_friendly/babybear.rs
@@ -30,18 +30,6 @@ impl FieldElement<Babybear31PrimeField> {
     }
 }
 
-impl PartialOrd for FieldElement<Babybear31PrimeField> {
-    fn partial_cmp(&self, other: &Self) -> Option<core::cmp::Ordering> {
-        self.representative().partial_cmp(&other.representative())
-    }
-}
-
-impl Ord for FieldElement<Babybear31PrimeField> {
-    fn cmp(&self, other: &Self) -> core::cmp::Ordering {
-        self.representative().cmp(&other.representative())
-    }
-}
-
 #[cfg(test)]
 mod test_babybear_31_bytes_ops {
     use super::Babybear31PrimeField;

diff --git a/math/src/field/fields/fft_friendly/stark_252_prime_field.rs b/math/src/field/fields/fft_friendly/stark_252_prime_field.rs
@@ -63,6 +63,7 @@ impl FieldElement<Stark252PrimeField> {
     }
 }
 
+#[allow(clippy::incorrect_partial_ord_impl_on_ord_type)]
 impl PartialOrd for FieldElement<Stark252PrimeField> {
     fn partial_cmp(&self, other: &Self) -> Option<core::cmp::Ordering> {
         self.representative().partial_cmp(&other.representative())

diff --git a/math/src/unsigned_integer/element.rs b/math/src/unsigned_integer/element.rs
@@ -36,6 +36,7 @@ pub struct UnsignedInteger<const NUM_LIMBS: usize> {
 
 // NOTE: manually implementing `PartialOrd` may seem unorthodox, but the
 // derived implementation had terrible performance.
+#[allow(clippy::incorrect_partial_ord_impl_on_ord_type)]
 impl<const NUM_LIMBS: usize> PartialOrd for UnsignedInteger<NUM_LIMBS> {
     fn partial_cmp(&self, other: &Self) -> Option<Ordering> {
         let mut i = 0;