Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate movement from tick #697

Merged
merged 12 commits into from
Jul 3, 2024
Merged

Separate movement from tick #697

merged 12 commits into from
Jul 3, 2024

Conversation

manucamejo
Copy link
Collaborator

@manucamejo manucamejo commented Jun 11, 2024 •
edited by Nico-Sanchez
Loading

Motivation

The movement is tied to the tickrate time.

Summary of changes

How to test it?

Play a game with the following client branch -> https://github.com/lambdaclass/champions_of_mirra/pull/1836

Checklist

  • Tested the changes locally.
  • Reviewed the changes on GitHub, line by line.
  • This change requires new documentation.
    • Documentation has been added/updated.

@Nico-Sanchez Nico-Sanchez marked this pull request as ready for review July 3, 2024 21:24
agustinesco
agustinesco approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@agustinesco agustinesco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agustinesco agustinesco merged commit 09a8487 into main Jul 3, 2024
18 of 19 checks passed
@agustinesco agustinesco deleted the movement-depending-on-time-instead-of-ticks branch July 3, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agustinesco agustinesco agustinesco approved these changes

@Nico-Sanchez Nico-Sanchez Nico-Sanchez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@manucamejo @Nico-Sanchez @agustinesco @mgrunwaldt