Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH-971-969] - Increase wall colliders and fix items not spawning inside the square #977

Merged
merged 6 commits into from
Nov 7, 2024

Conversation

tvillegas98
Copy link
Contributor

@tvillegas98 tvillegas98 commented Nov 6, 2024

Motivation

Having an square walls, is causing some troubles with things that could appear beyond these walls

Closes #971
Closes #969

Summary of changes

  • Increased map radius size
  • Increased external walls size (almost duplicataed)
  • Added an square wall field to map configurations

How to test it?

  • Play the game and check that the items spawns inside the square (you'll have to print the random position created in random_position_in_square/5 and check that they don't go over the walls)
  • Check that valtimer is not able to go trough the external walls

Checklist

  • Tested the changes locally.
  • Reviewed the changes on GitHub, line by line.
  • This change requires new documentation.
    • Documentation has been added/updated.

@tvillegas98 tvillegas98 changed the title [GH-971] - Increase wall colliders [GH-971-969] - Increase wall colliders and items not spawning inside the square Nov 6, 2024
@tvillegas98 tvillegas98 marked this pull request as ready for review November 6, 2024 17:33
@tvillegas98 tvillegas98 changed the title [GH-971-969] - Increase wall colliders and items not spawning inside the square [GH-971-969] - Increase wall colliders and fix items not spawning inside the square Nov 6, 2024
Copy link
Collaborator

@Nico-Sanchez Nico-Sanchez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a minor comment

apps/arena/lib/arena/game_updater.ex Outdated Show resolved Hide resolved
@manucamejo manucamejo merged commit 4c0a7aa into main Nov 7, 2024
1 check passed
@manucamejo manucamejo deleted the gh-969-increase-wall-colliders branch November 7, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Valtimer the Merliot escapist [BUG] - Items are not sparning inside merliot's map
3 participants