Add flamegraph of a Tx #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrancoGiachetta
requested review from
edg-l,
igaray,
azteca1998,
fmoletta and
pefontana
as code owners
pefontana
requested changes
Jul 8, 2024
docs/benchmarks/flamegraph.svg
Outdated
There was a problem hiding this comment.
We should not add the flamegraph to the repo!
README.md
Outdated
| cargo install flamegraph | ||
| ``` | ||
|
|
||
| #### Example |
There was a problem hiding this comment.
Lets put something like
To produce a flamegraph of a transaction execution run:
|
Changes were done |
|
The flamegraph looks a bit odd to me. I ran the command and saw that most of the samples are from
|
|
mmm, I see. To be honest, it looked strange to me, especially because it finishes quite fast. I guess I should take deeper look into it |
edg-l
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refers to #27
This PR adds a flamegraph of a random tx, so as to know how much time is spent in each part of the process of its execution.