From 5b8be3fbfe6fe2650994b47f16d3ff6686636ffe Mon Sep 17 00:00:00 2001
From: Mike Pirog <mike@lando.dev>
Date: Fri, 15 Nov 2024 15:08:26 -0500
Subject: [PATCH] attempted to make checksumming reusable part 6

---
 .github/workflows/generate-checksums.yml | 30 +++++++++++++++++++-----
 .github/workflows/pkg-binary.yml         | 10 ++++----
 2 files changed, 29 insertions(+), 11 deletions(-)

diff --git a/.github/workflows/generate-checksums.yml b/.github/workflows/generate-checksums.yml
index d972e9bf8..ff6cdfca0 100644
--- a/.github/workflows/generate-checksums.yml
+++ b/.github/workflows/generate-checksums.yml
@@ -4,29 +4,40 @@ on:
   workflow_call:
     inputs:
       artifact-name:
+        default:
         description: The artifact name to download for checksumming
+        required: false
         type: string
-        default:
       artifact-pattern:
+        default:
         description: The artifact pattern to download for checksumming
+        required: false
         type: string
-        default:
       depth:
+        default: "1"
         description: The depth to search for files to checksum
+        required: false
         type: string
-        default: "1"
       flatten:
+        default: false
         description: Whether to flatten all downloaded artifacts
+        required: false
         type: boolean
-        default: false
       output:
+        default: sha256sum.txt
         description: The name of the checksum file
+        required: false
         type: string
-        default: sha256sum.txt
       show:
+        default: true
         description: Whether to print the checksums in the action
+        required: false
         type: boolean
-        default: true
+      upload-name:
+        default: checksums-${{ github.sha }}
+        description: The artifact name to upload
+        required: false
+        type: string
 
 jobs:
   checksum:
@@ -58,3 +69,10 @@ jobs:
             --depth=${{ inputs.depth }} \
             --output=${{ inputs.output }} \
             ${{ inputs.show == true && '--show' || ''}}
+      - name: Upload checksums
+        uses: actions/upload-artifact@v4
+        with:
+          name: ${{ inputs.upload-name }}
+          path: ${{ inputs.output }}
+          if-no-files-found: error
+          retention-days: 1
diff --git a/.github/workflows/pkg-binary.yml b/.github/workflows/pkg-binary.yml
index 40b639681..0084e46dd 100644
--- a/.github/workflows/pkg-binary.yml
+++ b/.github/workflows/pkg-binary.yml
@@ -4,30 +4,30 @@ on:
   workflow_call:
     inputs:
       arch:
+        default: x64
         description: The architecture to build for eg x64 | arm64
         required: true
         type: string
-        default: x64
       node-version:
+        default: "20"
         description: The node version to build for eg 16 | 18 | 20
         required: true
         type: string
-        default: "20"
       os:
+        default: linux
         description: The os to build for eg linux | macos | win
         required: true
         type: string
-        default: linux
       filename:
+        default: lando
         description: The name of the resulting binary
         required: false
         type: string
-        default: lando
       fatcore:
+        default: false
         description: Whether to build a fat binary or not
         required: false
         type: boolean
-        default: false
 
 jobs:
   pkg-binary: