Contrib plus (#28)

* update contrib things and deyarn

* update contrib things and deyarn 2

* update contrib things 2

* update contrib things 3

* update contrib things 4

.github/PULL_REQUEST_TEMPLATE.md

@@ -0,0 +1,22 @@
+### Bare minimum self-checks
+
+> [What do you think of a person who only does the bare minimum?](https://getyarn.io/yarn-clip/dcf80710-425e-478b-bde1-c107bd11e849)
+- [ ] I've updated this PR with the latest code from `main`
+- [ ] I've done a cursory QA pass of my code locally
+- [ ] I've ensured all automated status check and tests pass
+- [ ] I've [connected this PR to an issue](https://help.zenhub.com/support/solutions/articles/43000010350-connecting-pull-requests-to-github-issues)
+
+### Pieces of flare
+
+- [ ] I've written a unit or functional test for my code
+- [ ] I've updated relevant documentation it my code changes it
+- [ ] I've updated this repo's README if my code changes it
+- [ ] I've updated this repo's CHANGELOG with my change unless its a trivial change (like updating a typo in the docs)
+
+### Finally
+
+- [ ] I've [requested a review](https://help.github.com/en/articles/requesting-a-pull-request-review) with relevant people
+
+If you have any issues or need help please join the `#contributors` channel in the [Lando slack](https://www.launchpass.com/devwithlando) and someone will gladly help you out!
+
+You can also check out the [coder guide](https://docs.lando.dev/contrib/coder.html).

.github/workflows/label-add-to-project.yml

@@ -0,0 +1,27 @@
+name: Add to DevOps Project
+
+on:
+  issues:
+    types: [labeled]
+  pull_request:
+    types: [labeled]
+
+jobs:
+  add_to_project:
+    runs-on: ${{ matrix.os }}
+    strategy:
+      fail-fast: false
+      matrix:
+        os:
+          - ubuntu-22.04
+        flag:
+          - flag
+
+    steps:
+      - name: Add issue/PR to GitHub Project
+        if: github.event.label.name == '${{ matrix.flag }}'
+        uses: actions/[email protected]
+        with:
+          project-url: https://github.com/orgs/lando/projects/10
+          github-token: ${{ secrets.SHADOW_COUNCIL_ESCALATOR }}
+          labeled: ${{ matrix.flag }}

.github/workflows/pr-linter.yml

@@ -11,7 +11,7 @@ jobs:
         os:
           - ubuntu-22.04
         node-version:
-          - '16'
+          - '20'
     steps:
       # Install deps and cache
       - name: Checkout code
@@ -20,10 +20,10 @@ jobs:
         uses: actions/setup-node@v3
         with:
           node-version: ${{ matrix.node-version }}
-          cache: yarn
-      - name: Install Yarn dependencies
-        run: yarn install --prefer-offline --frozen-lockfile
+          cache: npm
+      - name: Install dependencies
+        run: npm clean-install --prefer-offline --frozen-lockfile
 
       # Run the linter
       - name: Run code linter
-        run: yarn lint
+        run: npm run lint

.github/workflows/pr-tests.yml

@@ -12,9 +12,9 @@ jobs:
       fail-fast: false
       matrix:
         os:
-          - macos-12
+          - macos-13
         node-version:
-          - '16'
+          - '20'
 
     steps:
       - name: Checkout code
@@ -25,11 +25,11 @@ jobs:
         uses: actions/setup-node@v3
         with:
           node-version: ${{ matrix.node-version }}
-          cache: yarn
-      - name: Install Yarn dependencies
-        run: yarn install --prefer-offline --frozen-lockfile
+          cache: npm
+      - name: Install dependencies
+        run: npm clean-install --prefer-offline --frozen-lockfile
       - name: Package node binary
-        run: yarn build
+        run: npm run build
       - name: Sign
         uses: lando/code-sign-action@v2
         id: code-sign-action
@@ -65,11 +65,12 @@ jobs:
       fail-fast: false
       matrix:
         os:
-          - macos-12
+          - macos-13
         node-version:
-          - '16'
+          - '20'
         tool:
-          - altool
+          # altool is deprecated now and it throws an error if you try to use it
+          # - altool
           - notarytool
 
     steps:
@@ -81,11 +82,11 @@ jobs:
         uses: actions/setup-node@v3
         with:
           node-version: ${{ matrix.node-version }}
-          cache: yarn
-      - name: Install Yarn dependencies
-        run: yarn install --prefer-offline --frozen-lockfile
+          cache: npm
+      - name: Install dependencies
+        run: npm clean-install --prefer-offline --frozen-lockfile
       - name: Package node binary
-        run: yarn build
+        run: npm run build
       - name: Sign
         uses: lando/code-sign-action@v2
         id: code-sign-action

.github/workflows/release.yml

@@ -16,7 +16,7 @@ jobs:
         os:
           - ubuntu-22.04
         node-version:
-          - '16'
+          - '20'
 
     steps:
       - name: Checkout code
@@ -25,15 +25,15 @@ jobs:
         uses: actions/setup-node@v3
         with:
           node-version: ${{ matrix.node-version }}
-          cache: yarn
+          cache: npm
       - name: Install dependencies
-        run: yarn install
+        run: npm clean-install
       - name: Lint
-        run: yarn lint
+        run: npm run lint
       - name: Prepare release
         uses: lando/prepare-release-action@v3
         with:
-          commands: yarn prepare
+          commands: npm run prepare
           sync-token: ${{ secrets.RTFM47_COAXIUM_INJECTOR }}
           sync-email: [email protected]
           sync-username: rtfm-47

.gitignore

@@ -43,3 +43,4 @@ _site
 docs/.vuepress/.cache
 docs/.vuepress/.temp
 docs/.vuepress/dist
+yarn.lock

.node-version

@@ -1 +1 @@
-16
+18

.tool-versions

@@ -1 +1 @@
-nodejs 16
+nodejs 18

README.md

@@ -55,6 +55,11 @@ We try to log all changes big and small in both [THE CHANGELOG](https://github.c
 
 Create a release and publish to [GitHub Actions Marketplace](https://docs.github.com/en/enterprise-cloud@latest/actions/creating-actions/publishing-actions-in-github-marketplace). Note that the release tag must be a [semantic version](https://semver.org/).
 
+## Maintainers
+
+* [@pirog](https://github.com/pirog)
+* [@reynoldsalec](https://github.com/reynoldsalec)
+
 ## Contributors
 
 <a href="https://github.com/lando/notarize-action/graphs/contributors">

action.yml

@@ -41,5 +41,5 @@ outputs:
     description: "The path to the product that was notarized"
 
 runs:
-  using: "node16"
+  using: "node20"
   main: "dist/index.js"