-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add inline comment bubbles #155
Labels
Comments
Has anyone taken this feature? Can you assign to me |
Not yet, it's all yours @liuhuapiaoyuan! |
👏👏👏👏 |
hey @liuhuapiaoyuan going to unassign you from this, if you've already started feel free to still put a PR up though! |
Oh sorry, I've started processing, but I won't be able to submit the PR . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add UI support for inline comment bubbles. (See Loom video of how ChatGPT manages this). Do NOT implement any backend functionality for that in this PR. All this should do, is expose a React API which will allow us to later insert inline comments which are tied to specific text in the artifact, and highlights said text. This PR can however include logic which will update the highlighted text (not required, I/you can do in another PR).
The comment bubble should have an
X
(cancel/close) button, and anApply
button. To enable this, the data structure should have these two fields:The text was updated successfully, but these errors were encountered: