-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.0 - Test Configs #49
Comments
* Test_args will be removed
This will break existing tests that play heavily on the existence of test_args…
Jen
|
Yes, and no. |
Also, having multiple cmds per test is necessary for our design goals of reducing the need for runit scripts altogether, and that can't coexist with test_args in any reasonable way that I can think of. |
Elaborate on string substitution as a replacement for PV_TEST_ARGS?
|
I do believe I was mistaken about what test_args was actually doing. I thought they were getting appended to the command, but I guess they were just getting set as an environment variable? Maybe both? Regardless, under the new config schema, you would simply set PV_TEST_ARGS as an environment variable for the test run. The old runit scripts shouldn't break in that case. As for the string substitution, we're still settling on what that will look like. Both Nick and I have very different proposals, that are being discussed. |
Note: For the following, a 'test section' isn't the whole test yaml file like we're used to. It is the section of the config file that describes each test. These currently exist under a 'test name' key, and will continue to do so.
The following features will be added to test configuration:
a. A 'host' config containing a single test section for configuring things specific to that host.
b. Zero or more 'mode' configs that each contain a single test section, for setting various general running modes and scheduler settings.
c. A test config from a test config file containing one or more test sections in a yaml mapping.
The text was updated successfully, but these errors were encountered: