Sanity check for rebound #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamdempsey90
requested review from
brryan,
pdmullen and
111-1000
and removed request for
111-1000
|
The traceback is |
The failing function call in putting a print statement and a sleep in the writing function gives (serial cpu btw): so it's failing when writing |
And the full backtrace from @Yurlungur you were recently in this file. Do you have any idea if the changes you made could have caused something like this? It's like some pointer got corrupted, or something. |
|
It looks like one of your params is not being properly output as an attribute. Do you know which varaible it is failing on? In template <typename T>
void Params::WriteToHDF5AllParamsOfType(const std::string &prefix,
const HDF5::H5G &group) const {
for (const auto &p : myParams_) {
const auto &key = p.first;
const auto type = myTypes_.at(key);
if (type == std::type_index(typeid(T))) {
auto typed_ptr = dynamic_cast<Params::object_t<T> *>((p.second).get());
std::cout << "Writing param " << key << std::endl;
HDF5::HDF5WriteAttribute(prefix + "/" + key, *typed_ptr->pValue, group);
}
}
}this'll produce a lot of output. But whatever param it prints out right before the segfault should tell us what param is causing problems. (Unless of course the out of memory access happened somewhere completely different and it just segfaults here because we're lucky. Which is possible.) |
it fails pretty reliably when writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks that the particle allocation persists across the interface when we create the rebound simulation.
Background
Description of Changes
Checklist