Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version dependency issues #20

Open
ProtaLaz opened this issue Jun 23, 2016 · 1 comment
Open

Version dependency issues #20

ProtaLaz opened this issue Jun 23, 2016 · 1 comment

Comments

@ProtaLaz
Copy link

Just a quick heads-up for people who might want to try to use this package with x-ray:

Currently x-ray-phantom has a dependency on Nightmare 1.7.0, which in turn requires phantom 0.7.0, which is a deprecated version that only works with phantomjs 1.9.8 and earlier (the current version of phantomjs is v2+).

Essentially this means that using phantom to drive x-ray is pretty much broken unless you stick to legacy phantomjs. Further complicating the issue is the fact that the newer Nightmare (latest is 2.5.2) actually switched it's headless browser to electronjs instead of phantomjs.

@Ilshidur
Copy link

👍

I would like to add something about vulnerabilities :

As the nightmare package had a vulnerability on the electron-prebuilt package since version 2.0.0 and kind of fixed it in the version 2.8.1, I think it would be nice to at least update to [email protected] until the maintainers definitely fix the issue.

At the moment, x-ray-phantom only has this vulnerability according to Snyk (Known Vulnerabilities).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants