Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for sqlsrv #328

Closed
MiloDBD opened this issue Mar 12, 2024 · 3 comments
Closed

Support for sqlsrv #328

MiloDBD opened this issue Mar 12, 2024 · 3 comments
Assignees

Comments

@MiloDBD
Copy link

MiloDBD commented Mar 12, 2024

It is on the road map to support sqlsrv. I know many would like this.

Thank you

@jessarcher
Copy link
Member

Hi @MiloDBD,

I'm open to this, but I'm not sure what's involved. There are a few less common database techniques we use in Pulse, namely generated indexed hash columns and upsert queries, which have their own intricacies with each database engine. If you search the code base for sqlite, you'll see where each of these database-specific code paths live.

I'll add it to my list to look at, but please feel free to try a PR for it. I'd appreciate any guidance, especially on the most efficient way to store and index the generated hashes. In MySQL, we used a fixed-length binary column, but this doesn't column type doesn't exist on Postgres where it turned out that using a UUID column was a very efficient way to store an MD5 hash.

@timacdonald
Copy link
Member

And remember you can use a dedicated database for Pulse, so you can use sqlsrv for your application and spin up a dedicated mysql / postgres / sqlite database for Pulse itself.

@jessarcher
Copy link
Member

I just tried this in #329 to see if it was a quick win, but I couldn't get it to work. I'm going to close this for now, but we're open to PRs if you or anyone else can figure it out 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants