Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove NOTE #159

Open
monfera opened this issue Jan 6, 2017 · 1 comment
Open

Remove NOTE #159

monfera opened this issue Jan 6, 2017 · 1 comment

Comments

@monfera
Copy link

monfera commented Jan 6, 2017

I think this is not needed, makes it harder to read the final tap reader line with actual contents, and there's no option to disable it:
log('# NOTE: disabled specs are usually a result of xdescribe.');
Would a PR be accepted with this?

@putermancer
Copy link
Collaborator

A PR that added a config option to suppress debug messages like that would be accepted. The current behavior should not change for people who currently use the TAP reporter, but adding an option to make it quieter sounds fine.

The options should be passed similar to how they are for the JUnitXmlReporter (i.e. a single options object) and the options should be also be documented in the same way.

Thanks for your willingness to contribute!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants