Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reason for implementing 'to_json' #14

Open
MarkusHarmsen opened this issue Oct 22, 2014 · 2 comments
Open

Reason for implementing 'to_json' #14

MarkusHarmsen opened this issue Oct 22, 2014 · 2 comments

Comments

@MarkusHarmsen
Copy link
Contributor

Why has the Dish::Plate#to_json method been merged into 99ac61a?

It is quite complex and even contains platform specific dependencies (NSJSONSerialization). So let the user decide how he/she wants to use to_json. Any thoughts?

Furthermore it's not covered by any tests.
@MarkusHarmsen
Copy link
Contributor Author

I removed the to_json method and did some cleanup in my fork.
See: MarkusHarmsen/dish@lassebunk:master...master
I could create a pull request if desired ;)

@lassebunk
Copy link
Owner

I share your concerns. I'll work on this.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lassebunk @MarkusHarmsen