Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 FDML catalog #510

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

S3 FDML catalog #510

wants to merge 1 commit into from

Conversation

lindholc
Copy link
Member

@lindholc lindholc commented Oct 8, 2022

This is a Catalog that gets datasets from FDML files in S3.

I wrote the catalog implementation a few months ago, but only recently had the inspiration on how to test it. I just threw all this together as a POC. We'll want to clean it up some.

s3mock, which we've used in the past, is no longer maintained. I've heard of testcontainers in other contexts, so I figured I'd give it a shot. I'm using the LocalStack module. (There's also a different S3Mock that works with testcontainers that might be worth exploring.) It's pretty slow to start up, so maybe we don't run these tests every time.

I'm curious how easily these tests run locally for you. I had to do some extra setup because I'm using colima, but I managed to have it all handled outside of the build. It looks like it just works in GHA.

@lindholc
Copy link
Member Author

Consider switching from testcontainers to whale-tail.

@lindholc
Copy link
Member Author

I wonder if s3proxy using in-memory mode would be a less complicated way to test this. It can be embedded, so there's no need for Docker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants