Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a
Catalog
that gets datasets from FDML files in S3.I wrote the catalog implementation a few months ago, but only recently had the inspiration on how to test it. I just threw all this together as a POC. We'll want to clean it up some.
s3mock, which we've used in the past, is no longer maintained. I've heard of testcontainers in other contexts, so I figured I'd give it a shot. I'm using the LocalStack module. (There's also a different S3Mock that works with testcontainers that might be worth exploring.) It's pretty slow to start up, so maybe we don't run these tests every time.
I'm curious how easily these tests run locally for you. I had to do some extra setup because I'm using colima, but I managed to have it all handled outside of the build. It looks like it just works in GHA.