Allow constructing servers from HttpRoutes #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, servers could only be constructed using subclasses of ServiceInterface, which contain HttpRoutes. It would be useful for the auth use case to be able to manipulate these routes, but as written there was no way to do this. This commit gives us a way to manipulate routes from a service interface before using them to build a server.
dlindhol
reviewed
Oct 3, 2024
| @@ -52,6 +52,7 @@ object Latis3ServerBuilder { | |||
|
|
|||
| def defaultLandingPage: LandingPage = new DefaultLandingPage(makeServiceInfo("latis.util.BuildInfo$")) | |||
|
|
|||
| @annotation.targetName("mkServerOld") | |||
There was a problem hiding this comment.
This is new to me. What is the motivation?
There was a problem hiding this comment.
There are two mkServer methods, but the types after erasure are the same (the interfaces argument) so there needs to be another way to disambiguate.
https://docs.scala-lang.org/scala3/reference/other-new-features/targetName.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new
makeServermethod that acceptsHttpRoutesrather than subclasses ofServiceInterface(which contain routes). This allows us to manipulate the routes to enable auth without needing to change the definition of the service interface, among other things.