feat: add support for client-side prerequisite events #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwaldren-ld
force-pushed
the
cw/sdk-699-client-prereq-events
branch
from
a85bc56
to
992dded
Compare
cwaldren-ld
commented
Oct 15, 2024
| @@ -262,6 +270,15 @@ func evaluateAllShared(w http.ResponseWriter, req *http.Request, sdkKind basicty | |||
| } | |||
| valueObj.Maybe("debugEventsUntilDate", flag.DebugEventsUntilDate != 0). | |||
| Float64(float64(flag.DebugEventsUntilDate)) | |||
There was a problem hiding this comment.
All of this to say.. here's the new behavior implemented by the PR.
cwaldren-ld
force-pushed
the
cw/sdk-699-client-prereq-events
branch
from
af67c72
to
3668f83
Compare
cwaldren-ld
commented
Oct 16, 2024
| @@ -32,7 +33,8 @@ func (a *apiHelper) logResult(desc string, err error) error { | |||
| return nil | |||
| } | |||
| addInfo := "" | |||
| if gse, ok := err.(ldapi.GenericOpenAPIError); ok { | |||
| var gse *ldapi.GenericOpenAPIError | |||
| if errors.As(err, &gse) { | |||
There was a problem hiding this comment.
This little bug (the error is a pointer) was causing response bodies not to be logged.
cwaldren-ld
commented
Oct 16, 2024
| @@ -0,0 +1,131 @@ | |||
| //go:build integrationtests | |||
There was a problem hiding this comment.
This is a whole new builder scheme just for these tests - we need a simple way to create flags via REST API. The existing methods were single-purpose.
kinyoklion
approved these changes
Oct 17, 2024
cwaldren-ld
pushed a commit
that referenced
this pull request
Oct 21, 2024
🤖 I have created a release *beep* *boop* --- ## [8.10.0](v8.9.6...v8.10.0) (2024-10-17) ### Features * add support for client-side prerequisite events ([#452](#452)) ([9dea4b5](9dea4b5)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates Relay's client-side evaluation logic to track the top-level prerequisites associated with a flag.
These prerequisites are then passed back in the response as a
prerequisiteskey, allowing client-side SDKs to properly emit prerequisite events.