From e5dc67d23decb723dcc53ed21e063e7ecfcdebf2 Mon Sep 17 00:00:00 2001 From: Scrub <72096833+ScrubN@users.noreply.github.com> Date: Sun, 30 Jun 2024 00:42:03 -0400 Subject: [PATCH] Fix release workflow for real this time (#1118) * Speed up workflows by skipping manual restore command * Please build * Set download-artifact and upload-artifact to v4 --- .github/workflows/build-pr.yml | 22 ++++++++-------------- .github/workflows/build.yml | 22 ++++++++-------------- 2 files changed, 16 insertions(+), 28 deletions(-) diff --git a/.github/workflows/build-pr.yml b/.github/workflows/build-pr.yml index 7607c831..56901955 100644 --- a/.github/workflows/build-pr.yml +++ b/.github/workflows/build-pr.yml @@ -19,8 +19,6 @@ jobs: uses: actions/setup-dotnet@v4 with: dotnet-version: 6.0.x - - name: Restore Dependencies - run: dotnet restore TwitchDownloaderWPF - name: Build Windows GUI run: dotnet publish TwitchDownloaderWPF -p:PublishProfile=Windows -p:DebugType=Portable @@ -44,7 +42,7 @@ jobs: dest: TwitchDownloaderGUI-Windows-x64.zip - name: Upload Windows GUI Artifact Asset - uses: actions/upload-artifact@v4.3.3 + uses: actions/upload-artifact@v4 with: name: TwitchDownloaderGUI-Windows-x64.zip path: TwitchDownloaderGUI-Windows-x64.zip @@ -58,8 +56,6 @@ jobs: uses: actions/setup-dotnet@v4 with: dotnet-version: 6.0.x - - name: Restore Dependencies - run: dotnet restore TwitchDownloaderCLI - name: Build Windows CLI run: dotnet publish TwitchDownloaderCLI -p:PublishProfile=Windows -p:DebugType=Portable - name: Build Linux CLI @@ -102,31 +98,31 @@ jobs: dest: TwitchDownloaderCLI-LinuxArm64.zip - name: Upload Windows CLI Artifact Asset - uses: actions/upload-artifact@v4.3.3 + uses: actions/upload-artifact@v4 with: name: TwitchDownloaderCLI-Windows-x64.zip path: TwitchDownloaderCLI-Windows-x64.zip - name: Upload Linux CLI Artifact Asset - uses: actions/upload-artifact@v4.3.3 + uses: actions/upload-artifact@v4 with: name: TwitchDownloaderCLI-Linux-x64.zip path: TwitchDownloaderCLI-Linux-x64.zip - name: Upload LinuxAlpine CLI Artifact Asset - uses: actions/upload-artifact@v4.3.3 + uses: actions/upload-artifact@v4 with: name: TwitchDownloaderCLI-LinuxAlpine-x64.zip path: TwitchDownloaderCLI-LinuxAlpine-x64.zip - name: Upload LinuxArm CLI Artifact Asset - uses: actions/upload-artifact@v4.3.3 + uses: actions/upload-artifact@v4 with: name: TwitchDownloaderCLI-LinuxArm.zip path: TwitchDownloaderCLI-LinuxArm.zip - name: Upload LinuxArm64 CLI Artifact Asset - uses: actions/upload-artifact@v4.3.3 + uses: actions/upload-artifact@v4 with: name: TwitchDownloaderCLI-LinuxArm64.zip path: TwitchDownloaderCLI-LinuxArm64.zip @@ -140,8 +136,6 @@ jobs: uses: actions/setup-dotnet@v4 with: dotnet-version: 6.0.x - - name: Restore Dependencies - run: dotnet restore TwitchDownloaderCLI - name: Build MacOS CLI run: dotnet publish TwitchDownloaderCLI -p:PublishProfile=MacOS -p:DebugType=Portable - name: Build MacOSArm64 CLI @@ -160,13 +154,13 @@ jobs: dest: TwitchDownloaderCLI-MacOSArm64.zip - name: Upload MacOS CLI Artifact Asset - uses: actions/upload-artifact@v4.3.3 + uses: actions/upload-artifact@v4 with: name: TwitchDownloaderCLI-MacOS-x64.zip path: TwitchDownloaderCLI-MacOS-x64.zip - name: Upload MacOSArm64 CLI Artifact Asset - uses: actions/upload-artifact@v4.3.3 + uses: actions/upload-artifact@v4 with: name: TwitchDownloaderCLI-MacOSArm64.zip path: TwitchDownloaderCLI-MacOSArm64.zip diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index cc56f199..c15063fa 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -27,9 +27,9 @@ jobs: run: | expr "${{ steps.create_release.outputs.upload_url }}" > upload_url.txt - name: Upload URL - uses: actions/upload-artifact@v4.3.3 + uses: actions/upload-artifact@v4 with: - name: upload_url + name: upload_url.txt path: upload_url.txt build-gui: @@ -44,8 +44,6 @@ jobs: uses: actions/setup-dotnet@v4 with: dotnet-version: 6.0.x - - name: Restore Dependencies - run: dotnet restore TwitchDownloaderWPF - name: Build Windows GUI run: dotnet publish TwitchDownloaderWPF -p:PublishProfile=Windows -p:DebugType=Embedded @@ -69,9 +67,9 @@ jobs: dest: TwitchDownloaderGUI-${{ github.event.inputs.release_tag }}-Windows-x64.zip - name: Download URL - uses: actions/download-artifact@v2 + uses: actions/download-artifact@v4 with: - name: upload_url + name: upload_url.txt - name: Read URL id: url @@ -99,8 +97,6 @@ jobs: uses: actions/setup-dotnet@v4 with: dotnet-version: 6.0.x - - name: Restore Dependencies - run: dotnet restore TwitchDownloaderCLI - name: Build Windows CLI run: dotnet publish TwitchDownloaderCLI -p:PublishProfile=Windows -p:DebugType=Embedded - name: Build Linux CLI @@ -143,9 +139,9 @@ jobs: dest: TwitchDownloaderCLI-${{ github.event.inputs.release_tag }}-LinuxArm64.zip - name: Download URL - uses: actions/download-artifact@v2 + uses: actions/download-artifact@v4 with: - name: upload_url + name: upload_url.txt - name: Read URL id: url @@ -212,8 +208,6 @@ jobs: uses: actions/setup-dotnet@v4 with: dotnet-version: 6.0.x - - name: Restore Dependencies - run: dotnet restore TwitchDownloaderCLI - name: Build MacOS CLI run: dotnet publish TwitchDownloaderCLI -p:PublishProfile=MacOS -p:DebugType=Embedded - name: Build MacOSArm64 CLI @@ -232,9 +226,9 @@ jobs: dest: TwitchDownloaderCLI-${{ github.event.inputs.release_tag }}-MacOSArm64.zip - name: Download URL - uses: actions/download-artifact@v2 + uses: actions/download-artifact@v4 with: - name: upload_url + name: upload_url.txt - name: Read URL id: url