Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isEnum should also accept an enumeration object #25

Open
lazarljubenovic opened this issue Oct 25, 2019 · 0 comments
Open

isEnum should also accept an enumeration object #25

lazarljubenovic opened this issue Oct 25, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@lazarljubenovic
Copy link
Owner

lazarljubenovic commented Oct 25, 2019

Instead of writing

export const isLanguageCode = tg.isEnum(...enumValues(LanguageCode))

where enumValues is a function defied as follows

export function enumValues<T extends object> (enumeration: T): Array<T[keyof T]> {
  return objectKeys(enumeration)
    .filter(k => isNaN(Number(k)))
    .map(k => enumeration[k])
}

allow the consumer to simply write

export const isLanguageCode = tg.isEnum(LanguageCode)

Maybe deprecate listing all values and create a new guard for that?

@lazarljubenovic lazarljubenovic added the enhancement New feature or request label Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant