Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connection::isSecure method is untrusted #15

Closed
AmraniCh opened this issue Aug 5, 2021 · 0 comments · Fixed by #16
Closed

Connection::isSecure method is untrusted #15

AmraniCh opened this issue Aug 5, 2021 · 0 comments · Fixed by #16

Comments

@AmraniCh
Copy link
Member

AmraniCh commented Aug 5, 2021

Description

Since the PHP FTP extension provides only an explicit FTP over SSL/TLS connections (ftp_ssl_connect), we cannot determine if a successful connection is handled secured or not, therefore the ConnectionInterface::isSecure method is untrusted and shouldn't depend on it.

Suggestion

Deprecating of ConnectionInterface::isSecure and remove it from future releases.
@AmraniCh AmraniCh pinned this issue Aug 7, 2021
@AmraniCh AmraniCh closed this as completed Aug 7, 2021
@AmraniCh AmraniCh linked a pull request Aug 8, 2021 that will close this issue
ConnectionInterface::isSecure Deprecated #16
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ConnectionInterface::isSecure Deprecated lazzard/php-ftp-client
1 participant
@AmraniCh