Recursive deletion of directories

[skurrilewelt]

Tried to remove a directory structure like this:

-root
--content
----file1
----file2
----subdir
------file4
------file3

and the method FtpClient::removeDir(directory) doesn't jumps in to the subdir and as a result the directory content will not be deleted as intended.

Change line 373 in mentioned class to:
$this->removeDir($fileInfo['path']);
will solve this issue. Or miss I something?

[AmraniCh]

Hey, thanks for opening this issue.

print_r($this->isDir("root/content/subdir"));

Check this and see what result you will get, it must be true, otherwise we will use another method listDirDetails to see details about the file root/content/subdir and guess what the problem with it!

[skurrilewelt]

I think, it is obvious. You can't call rmdir because it won't delete directories which are not empty.

[AmraniCh]

The removeDir method should delete everything within a directory whether it's a file or a directory.

[skurrilewelt]

Don't know, why you closed this without looking into your code:

public function removeDir(string $directory) : bool
    {
        $list = array_reverse($this->listDirDetails($directory, true));
        foreach ($list as $fileInfo) {
            if ($fileInfo['type'] === 'file') {
                $this->wrapper->delete($fileInfo['path']);
                continue;
            }
            $this->wrapper->rmdir($fileInfo['path']);
        }

        return $this->wrapper->rmdir($directory);
    }

There is the recursive call to removeDir missing, in fact you call rmdir which won't works

[AmraniCh]

Hi @skurrilewelt

I closed the issue because of no response from your end, and I explained that the removeDir should recursively remove all the files and directories, and you have not provided any additional information about your issues like the directory structure or the error message.

Please share the output of this command:

 $list = array_reverse($this->listDirDetails($directory, true));
print($list);

You have to know that some FTP servers may have different implementations of the FTP specification and its extensions, so we are not expecting our library methods to work perfectly with all FTP servers.

If you share additional info we can guess what your FTP server is doing differently to update our code and finally fix the issue.

thanks for your understanding!