Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arithmetic expressions are not being split into operators and operands #191

Open
darenkeck-dev opened this issue Aug 26, 2022 · 1 comment

Comments

@darenkeck-dev
Copy link
Collaborator

Arithmetic expressions are not being split split into operands and operators. This potentially is an issue with the modelica-json parser or our own parser.

If you look at the parameter: "Buildings.Templates.Components.Fans.ArrayVariable.volInl"

The linkage schema output of that parameter looks as follows:

    {
      "modelicaPath": "Buildings.Templates.Components.Fans.ArrayVariable.volInl",
      "type": "Fluid.Delays.DelayFirstOrder",
      "value": "",
      "name": "Fluid volume at inlet",
      "group": "",
      "tab": "",
      "visible": false,
      "inputs": [],
      "modifiers": {
        ...
        "Buildings.Templates.Components.Fans.ArrayVariable.nPorts": {
          "operator": "none",
          "operands": [
            "nFan +1"
          ]
        }
      },

The operand is nFan +1 when it should be a new expression with an operator of '+' and two operands.

This is also true for subtraction if you refer to Buildings.Fluid.Interfaces.PartialTwoPartInterface.dp which generates an operand of port_a.p -port_b.p.

@darenkeck-dev darenkeck-dev added bug Something isn't working Top Priority Top of the Priority List labels Aug 26, 2022
@darenkeck-dev darenkeck-dev added this to the 01: Parser (BE) milestone Aug 26, 2022
@akapoor66 akapoor66 removed bug Something isn't working Top Priority Top of the Priority List labels Nov 17, 2022
@akapoor66 akapoor66 removed their assignment Nov 22, 2022
@AntoineGautier
Copy link
Collaborator

This is still open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants