diff --git a/.changeset/serious-moons-sleep.md b/.changeset/serious-moons-sleep.md new file mode 100644 index 000000000..def870460 --- /dev/null +++ b/.changeset/serious-moons-sleep.md @@ -0,0 +1,5 @@ +--- +'frontend-gelinkt-notuleren': patch +--- + +Wrap downloaded docs for correct uf8 diff --git a/.changeset/two-walls-move.md b/.changeset/two-walls-move.md new file mode 100644 index 000000000..0c76129e5 --- /dev/null +++ b/.changeset/two-walls-move.md @@ -0,0 +1,5 @@ +--- +'frontend-gelinkt-notuleren': patch +--- + +Update the date time picker to use the au time picker diff --git a/CHANGELOG.md b/CHANGELOG.md index ddb1d5e7a..9e0cba8cc 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,11 @@ # frontend-gelinkt-notuleren +## 5.44.1 + +### Patch Changes + +- [`b92513e`](https://github.com/lblod/frontend-gelinkt-notuleren/commit/b92513eea5a3afec6d230f86fb54d2ccdcd75115) Thanks [@elpoelma](https://github.com/elpoelma)! - Revert accidental `shouldEditRdfa` change + ## 5.44.0 ### Minor Changes diff --git a/app/components/date-time-picker.hbs b/app/components/date-time-picker.hbs index c000f7290..552d34e0b 100644 --- a/app/components/date-time-picker.hbs +++ b/app/components/date-time-picker.hbs @@ -11,30 +11,16 @@ /> {{/let}} -
- {{#let (unique-id) as |id|}} - {{t 'date-time-picker.hours'}} - - {{/let}} -
-
- {{#let (unique-id) as |id|}} - {{t 'date-time-picker.minutes'}} - - {{/let}} +
+
\ No newline at end of file diff --git a/app/components/date-time-picker.js b/app/components/date-time-picker.js index 1c751d640..36d7eb0ac 100644 --- a/app/components/date-time-picker.js +++ b/app/components/date-time-picker.js @@ -49,18 +49,11 @@ export default class DateTimePicker extends Component { } @action - onChangeTime(type, event) { - const value = event.target.value; - if (!this.date) { - this.date = new Date(); - } - if (type === 'hours') { - if (value < 0 || value > 24) return; - this.date.setHours(value); - } else { - if (value < 0 || value > 60) return; - this.date.setMinutes(value); - } + onChangeTime(timeObject) { + if (!this.date) this.date = new Date(); + this.date.setHours(timeObject.hours); + this.date.setMinutes(timeObject.minutes); + this.date.setSeconds(timeObject.seconds); this.args.onChange(this.date); } } diff --git a/app/components/download-meeting-part.gjs b/app/components/download-meeting-part.gjs index b705f72b7..e03e2ad3a 100644 --- a/app/components/download-meeting-part.gjs +++ b/app/components/download-meeting-part.gjs @@ -5,8 +5,9 @@ import { on } from '@ember/modifier'; import { task } from 'ember-concurrency'; import perform from 'ember-concurrency/helpers/perform'; import { generateExportTextFromEditorDocument } from 'frontend-gelinkt-notuleren/utils/generate-export-from-editor-document'; +import { wrapDownloadedDocument } from 'frontend-gelinkt-notuleren/utils/wrap-downloaded-document'; -export default class DownloadMeetingComponent extends Component { +export default class DownloadMeetingPartComponent extends Component { @service publish; @service intl; @@ -14,7 +15,7 @@ export default class DownloadMeetingComponent extends Component { return this.args.buttonSkin || 'link'; } get icon() { - return this.downloadMeeting.last?.isSuccessful + return this.downloadMeetingPart.last?.isSuccessful ? 'circle-check' : this.args.icon; } @@ -29,7 +30,7 @@ export default class DownloadMeetingComponent extends Component { ); } - downloadMeeting = task(async () => { + downloadMeetingPart = task(async () => { let route = `/prepublish/${this.args.documentType}`; let html; switch (this.args.documentType) { @@ -59,7 +60,9 @@ export default class DownloadMeetingComponent extends Component { if (this.args.callback) { return this.args.callback(html); } else { - const file = new Blob([html], { type: 'text/html' }); + const file = new Blob([wrapDownloadedDocument(html)], { + type: 'text/html', + }); const linkElement = document.createElement('a'); linkElement.href = URL.createObjectURL(file); linkElement.download = `${this.args.documentType}.html`; @@ -109,15 +112,15 @@ export default class DownloadMeetingComponent extends Component { - {{#if this.downloadMeeting.last.isSuccessful}} + {{#if this.downloadMeetingPart.last.isSuccessful}} {{this.completedText}} {{else}} {{this.buttonText}} diff --git a/app/controllers/meetings/download/index.js b/app/controllers/meetings/download/index.js index a83aebcc0..ab07eba71 100644 --- a/app/controllers/meetings/download/index.js +++ b/app/controllers/meetings/download/index.js @@ -4,6 +4,7 @@ import { restartableTask, task } from 'ember-concurrency'; import { trackedTask } from 'reactiveweb/ember-concurrency'; import InstallatieVergaderingModel from 'frontend-gelinkt-notuleren/models/installatievergadering'; import { service } from '@ember/service'; +import { wrapDownloadedDocument } from '../../../utils/wrap-downloaded-document'; export default class MeetingsDownloadController extends Controller { @service publish; @@ -53,7 +54,9 @@ export default class MeetingsDownloadController extends Controller { }); downloadHtml(html, documentName) { - const file = new Blob([html], { type: 'text/html' }); + const file = new Blob([wrapDownloadedDocument(html)], { + type: 'text/html', + }); const linkElement = document.createElement('a'); linkElement.href = URL.createObjectURL(file); linkElement.download = `${documentName}.html`; diff --git a/app/templates/agendapoints/edit.hbs b/app/templates/agendapoints/edit.hbs index 4b0244e34..22142aa39 100644 --- a/app/templates/agendapoints/edit.hbs +++ b/app/templates/agendapoints/edit.hbs @@ -98,7 +98,7 @@ @widgets={{this.widgets}} @nodeViews={{this.nodeViews}} @plugins={{this.plugins}} - @shouldEditRdfa={{true}} + @shouldEditRdfa={{false}} @shouldShowRdfa={{true}} > <:toolbar> diff --git a/app/utils/wrap-downloaded-document.js b/app/utils/wrap-downloaded-document.js new file mode 100644 index 000000000..565da0cc6 --- /dev/null +++ b/app/utils/wrap-downloaded-document.js @@ -0,0 +1,14 @@ +export function wrapDownloadedDocument(html) { + const document = ` + + + + + + + ${html} + + + `; + return document; +} diff --git a/package-lock.json b/package-lock.json index 259812557..0c3bbbd31 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "frontend-gelinkt-notuleren", - "version": "5.44.0", + "version": "5.44.1", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "frontend-gelinkt-notuleren", - "version": "5.44.0", + "version": "5.44.1", "license": "MIT", "dependencies": { "@curvenote/prosemirror-utils": "^1.0.5", diff --git a/package.json b/package.json index c1bc61777..24eb84ac8 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "frontend-gelinkt-notuleren", - "version": "5.44.0", + "version": "5.44.1", "private": true, "description": "Ember frontend of the Gelinkt Notuleren application", "repository": {