Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getList() orderBy documentation is vague #46

Open
Abadulrehman opened this issue Aug 24, 2021 · 0 comments
Open

getList() orderBy documentation is vague #46

Abadulrehman opened this issue Aug 24, 2021 · 0 comments

Comments

@Abadulrehman
Copy link

The renovation-core documentation currently has the following definition of the orderBy argument of getList():
Screenshot from 2021-08-24 22-31-31
...while the actual argument looks something a little more like this:

this.$renovation.model.getList({
      doctype: 'Clients',
      fields: ['client_name, logo'],
      orderBy: '`tabClients`.`name` asc',
    })

A little tweaking of the description, or a full example could save someone inexperienced with frappe much time wasted. 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant