Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for apollo file uploads, resolves #61 #62

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Andy2003
Copy link

@Andy2003 Andy2003 commented Oct 28, 2019

add support for apollo file uploads, resolves #61

@kaqqao
Copy link
Member

kaqqao commented Nov 4, 2019

Had only a brief look, but it seems great! Thanks a bunch for the contribution!
I'll check it out in detail and merge as soon as I get a chance.

@Andy2003 Andy2003 force-pushed the deature/file-upload branch from 3ec0028 to 982036f Compare January 26, 2020 00:29
@kaqqao
Copy link
Member

kaqqao commented Jan 31, 2020

Finally got the timer to pick up this project again.
It seems this PR also includes the changes you made for #60. Could you please split them correctly because the other PR needs some changes before it can be merged (see my comments there). Plus it's better to keep the two sets of changes separate anyway as they deal with different issues.

@Andy2003 Andy2003 force-pushed the deature/file-upload branch from 982036f to 2b29882 Compare February 2, 2020 16:37
@Andy2003 Andy2003 requested a review from kaqqao February 2, 2020 16:41
@rijine
Copy link

rijine commented May 4, 2020

@kaqqao any action on this?

@kalyanmantri
Copy link

@kaqqao any update on this?

@Andy2003 Andy2003 force-pushed the deature/file-upload branch from 2b29882 to 70229cc Compare August 15, 2023 08:38
@mz-heesun
Copy link

@kaqqao Hope the work is completed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for apollo file uploads
5 participants