io.leangen.graphql.spqr.spring.web.GraphQLController should be fixed to treat variables as optional parameter

[slavap]

In executeJsonPost()

Map<String, Object> variables = requestParams.getVariables() == null ? requestBody.getVariables() : requestParams.getVariables();
// the following line must be added:
if (variables == null) variables = new HashMap<>();

Without this fix for example Voyager tool is not working, and I have to register custom GraphQLServletExecutor like this one:

public class SafeGraphQLExecutor extends DefaultGraphQLExecutor {

    public SafeGraphQLExecutor(ServletContextFactory contextFactory,
                               DataLoaderRegistryFactory dataLoaderRegistryFactory) {
        super(contextFactory, dataLoaderRegistryFactory);
    }

    @Override
    public Map<String, Object> execute(GraphQL graphQL, GraphQLRequest graphQLRequest, NativeWebRequest nativeRequest) {
        final GraphQLRequest req;
        if (graphQLRequest.getVariables() == null) {
            String query = graphQLRequest.getQuery();
            String operationName = graphQLRequest.getOperationName();
            Map<String, Object> variables = new HashMap<>();
            req = new GraphQLRequest(query, operationName, variables);

        } else {
            req = graphQLRequest;
        }
        return super.execute(graphQL, req, nativeRequest);
    }

}

[kaqqao]

Wrong project. Duplicate issue. Will be fixed soon.