This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
refactor(combinatorics/simple_graph/basic): Review delete_edges API
#18257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YaelDillies
added
awaiting-review
kmill
reviewed
Jan 23, 2023
| @[simp] lemma from_edge_set_inf (s t : set (sym2 V)) : | ||
| from_edge_set s ⊓ from_edge_set t = from_edge_set (s ∩ t) := | ||
| @[simp] lemma from_edge_set_inter (s t : set (sym2 V)) : | ||
| from_edge_set (s ∩ t) = from_edge_set s ⊓ from_edge_set t := |
There was a problem hiding this comment.
I think this is the wrong direction in practice. The reason it undistributes from_edge_set is that I expect most of the time there is more you can say about unions of sets than infima of graphs.
There was a problem hiding this comment.
I find distributivity lemmas often more useful because they let the operations distribute further along the chain. simp undistributivity lemmas are very rare for a reason.
In that case, we now have a bunch of lemmas distributing infimum over other graph operations, so this simp lemma is in the way, as it stands.
|
Ported as #18257. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redefine
simple_graph.delete_edgesas was discussed several times. Refactor proofs to take advantage of the new definition, and drop lemmas that are direct consequences of existing ones in order to make the API more modular.