-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: verify toList
for hash maps
#6954
Conversation
This is currently WIP. If you think further lemmas are useful let me know. One lemma is currently unproven, because there are some problems with casting. As with previous PRs I will first only work in Internal/RawLemmas.lean. |
Mathlib CI status (docs):
|
|
I am sorry, I wanted to rebase my PR to get rid of the merge conflict, but this somehow created all the extra review requests. How to fix this? Shall I close this and open a new one and readd my contributions? |
Since the PR is still a draft the review requests should go away again once you fix your branch to only contain the correct commits. |
It's difficult to review while the GitHub diff view is confused so I'll wait until you repaired your git history, but I have one remark: the new results in |
Ok, I have repaired it and used your changes. Additionally, I dropped lemmas in |
changelog-library |
Interesting that "CI / Linux release (pull_request)" works again. Not sure what went wrong last time, seemed to be unconnected with my PR. |
The |
awaiting-review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add 5a21fa9 to your PR? It's a quick test that simp
applies the right lemmas in lawful and non-lawful contexts.
awaiting-review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work as always, thanks!
This PR verifies the
toList
function for hash maps and dependent hash maps.