Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: min, max, minKey, maxKey, atIndex, getEntryLE, getKeyLE, ... functions for the tree map #7070

Merged
merged 19 commits into from
Feb 17, 2025

Conversation

datokrat
Copy link
Contributor

@datokrat datokrat commented Feb 13, 2025

This PR implements the methods min, max, minKey, maxKey, atIndex, getEntryLE, getKeyLE and consorts on the tree map.

In order to implement the proof-based functions such as min and getEntryLT in Queries.lean, it was necessary to extract Balanced and Ordered into new files so that they can be used from Queries.lean.

@datokrat datokrat added the changelog-library Library label Feb 13, 2025
@datokrat datokrat force-pushed the paul/treemap-minmax branch from eafc844 to ad314cc Compare February 13, 2025 21:21
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc February 13, 2025 21:32 Inactive
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Feb 13, 2025
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Feb 13, 2025

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 40c6dfa3ae15457501f8b603128d131a30a3784d --onto ae9d12aeaa075578c7ee3a5a585d0f9fb89cedd2. (2025-02-13 21:57:52)
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 2649d1510e6f1d1503d8cefbc87470ebdd3b05e1 --onto f50b863868a3625dfbca4fd2ad777d187632b1d4. (2025-02-17 11:06:44)
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 2649d1510e6f1d1503d8cefbc87470ebdd3b05e1 --onto 88664e4a995883877a5d85211a5cfab0a672b5ed. (2025-02-17 14:03:08)

@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc February 13, 2025 22:37 Inactive
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc February 14, 2025 08:52 Inactive
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc February 14, 2025 13:36 Inactive
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc February 14, 2025 13:49 Inactive
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc February 14, 2025 14:42 Inactive
@datokrat datokrat marked this pull request as ready for review February 14, 2025 23:26
@datokrat datokrat requested a review from TwoFX as a code owner February 14, 2025 23:26
src/Std/Classes/Ord.lean Outdated Show resolved Hide resolved
src/Std/Data/DTreeMap/Basic.lean Outdated Show resolved Hide resolved
src/Std/Data/DTreeMap/Internal/Def.lean Outdated Show resolved Hide resolved
src/Std/Data/DTreeMap/Internal/Queries.lean Outdated Show resolved Hide resolved
src/Std/Data/DTreeMap/Internal/Queries.lean Outdated Show resolved Hide resolved
src/Std/Data/DTreeMap/Internal/Queries.lean Outdated Show resolved Hide resolved
src/Std/Data/DTreeMap/Internal/Queries.lean Outdated Show resolved Hide resolved
src/Std/Data/DTreeMap/Internal/Queries.lean Outdated Show resolved Hide resolved
src/Std/Data/DTreeMap/Internal/Queries.lean Outdated Show resolved Hide resolved
src/Std/Data/DTreeMap/Raw.lean Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc February 17, 2025 10:48 Inactive
Copy link
Member

@TwoFX TwoFX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/Std/Data/DTreeMap/Internal/Queries.lean Outdated Show resolved Hide resolved
src/Std/Data/DTreeMap/Internal/Queries.lean Outdated Show resolved Hide resolved
@datokrat datokrat enabled auto-merge February 17, 2025 13:48
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc February 17, 2025 13:50 Inactive
@datokrat datokrat added this pull request to the merge queue Feb 17, 2025
Merged via the queue into master with commit 3599e43 Feb 17, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-library Library toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants