Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: rename UIntX.ofNatCore, UIntX.ofNat' -> UIntX.ofNatLT #7071

Merged
merged 3 commits into from
Feb 14, 2025
Merged

chore: rename UIntX.ofNatCore, UIntX.ofNat' -> UIntX.ofNatLT #7071

merged 3 commits into from
Feb 14, 2025

Conversation

TwoFX
Copy link
Member

@TwoFX TwoFX commented Feb 13, 2025

This PR unifies the existing functions UIntX.ofNatCore and UIntX.ofNat' under a new name, UIntX.ofNatLT.

@TwoFX TwoFX added the changelog-library Library label Feb 13, 2025
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Feb 13, 2025
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 80c8837f49ac95c03af15abdf2b350ad669d7d18 --onto ae9d12aeaa075578c7ee3a5a585d0f9fb89cedd2. (2025-02-13 17:07:45)

@TwoFX TwoFX marked this pull request as draft February 13, 2025 18:33
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc February 14, 2025 06:27 Inactive
@TwoFX TwoFX marked this pull request as ready for review February 14, 2025 06:58
@TwoFX TwoFX added this pull request to the merge queue Feb 14, 2025
Merged via the queue into master with commit 47548aa Feb 14, 2025
16 checks passed
tobiasgrosser pushed a commit to opencompl/lean4 that referenced this pull request Feb 16, 2025
@TwoFX @tobiasgrosser
chore: rename UIntX.ofNatCore, UIntX.ofNat' -> UIntX.ofNatLT (l…
1c522cc 
…eanprover#7071)

This PR unifies the existing functions `UIntX.ofNatCore` and
`UIntX.ofNat'` under a new name, `UIntX.ofNatLT`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kim-em kim-em Awaiting requested review from kim-em kim-em is a code owner

@leodemoura leodemoura Awaiting requested review from leodemoura leodemoura is a code owner

Assignees
No one assigned
Labels
changelog-library Library toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TwoFX @leanprover-community-bot